From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBR0e-0001PP-4u for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:42:04 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBR0d-0001N2-35 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:42:03 -0500 Received: from [199.232.76.173] (port=42794 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBR0c-0001Mm-V5 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:42:02 -0500 Received: from mx2.redhat.com ([66.187.237.31]:49100) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBR0c-0001J0-Gk for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:42:02 -0500 Message-ID: <49438371.9060304@redhat.com> Date: Sat, 13 Dec 2008 11:42:09 +0200 From: Avi Kivity MIME-Version: 1.0 References: <4940F9B5.9080206@amd.com> <49427CE1.4050108@codemonkey.ws> In-Reply-To: <49427CE1.4050108@codemonkey.ws> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/3] NUMA: promoting NUMA topology to BIOS and pin guest memory Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Andre Przywara , qemu-devel@nongnu.org Anthony Liguori wrote: > > At this point, I'm okay with introducing the libnuma dependency for > memory pinning. I'm not sure I think we should even present this as a > command line option though. I think the command line option should > just specify the NUMA topology and then we should use a monitor > command for pinning (as you do on your next patch). It's helpful to have static pinning from the command line. That's useful for quick tests for those of us who don't use management interfaces. Since the monitor and command line can share code, there shouldn't be any cost to this. -- I have a truly marvellous patch that fixes the bug which this signature is too narrow to contain.