From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBRFF-0003EP-5B for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:57:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBRFD-0003ED-Jg for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:57:08 -0500 Received: from [199.232.76.173] (port=52546 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBRFD-0003EA-HG for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:57:07 -0500 Received: from fmmailgate01.web.de ([217.72.192.221]:49579) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBRFC-0002wW-S2 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 04:57:07 -0500 Received: from smtp07.web.de (fmsmtp07.dlan.cinetic.de [172.20.5.215]) by fmmailgate01.web.de (Postfix) with ESMTP id 859DBFA858F1 for ; Sat, 13 Dec 2008 10:57:02 +0100 (CET) Received: from [88.64.11.10] (helo=[192.168.1.198]) by smtp07.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1LBRF8-0006KG-00 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 10:57:02 +0100 Message-ID: <494386C7.80703@web.de> Date: Sat, 13 Dec 2008 10:56:23 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <49437EF9.6000704@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig5364B9219121DA7BF61D8953" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [5998] Fix TARGET_LONG_BITS warning in TCG Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig5364B9219121DA7BF61D8953 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Blue Swirl wrote: > On 12/13/08, Jan Kiszka wrote: >> Blue Swirl wrote: >> > Revision: 5998 >> > http://svn.sv.gnu.org/viewvc/?view=3Drev&root=3Dqemu&revi= sion=3D5998 >> > Author: blueswir1 >> > Date: 2008-12-13 08:16:43 +0000 (Sat, 13 Dec 2008) >> > >> > Log Message: >> > ----------- >> > Fix TARGET_LONG_BITS warning in TCG >> > >> > Looking at tcg/tcg.c:828, the bug that the warning indicated would = show up as >> > incorrect PC shown in log, only on 32 bit big endian host emulating= a 64 bit >> > target, -d op flag enabled. Now that dyngen is gone, the patch can = be applied. >> > >> > Modified Paths: >> > -------------- >> > trunk/tcg/tcg-runtime.c >> > >> > Modified: trunk/tcg/tcg-runtime.c >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> > --- trunk/tcg/tcg-runtime.c 2008-12-12 20:02:52 UTC (rev 5997) >> > +++ trunk/tcg/tcg-runtime.c 2008-12-13 08:16:43 UTC (rev 5998) >> > @@ -29,6 +29,7 @@ >> > >> > #include "config.h" >> > #include "osdep.h" >> > +#include "cpu.h" // For TARGET_LONG_BITS >> > #include "tcg.h" >> > >> > int64_t tcg_helper_shl_i64(int64_t arg1, int64_t arg2) >> > >> >> >> Nice that this warning is finally fixed - but what is the point of >> including all those headers at all here? [1] worked well for me while= >> reducing dependencies. >=20 > I think all header files should be checked and even reorganized when > necessary. One item is the dyngen removal, cpu.h/exec.h distinction is > not clear for all targets and headers used by both user and system > emulators could be adjusted. Header files in hw should be OK, but > worth checking. Header dependencies and usage policies should be rechecked and probably cleaned up now, no question (see also my dyngen-exec.h problems). But here I was referring to the need of this _particular_ C file for any header except inttypes.h. Why including headers _here_ for no use? Jan --------------enig5364B9219121DA7BF61D8953 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAklDhtMACgkQniDOoMHTA+nhIQCdG0cVhpODkzqnj93cfvA82ns2 k98AnisxqIpr9zjNvWwOFtwDGVqMEKGj =As3P -----END PGP SIGNATURE----- --------------enig5364B9219121DA7BF61D8953--