From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBSqv-0004uL-MQ for qemu-devel@nongnu.org; Sat, 13 Dec 2008 06:40:09 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBSqt-0004tG-0y for qemu-devel@nongnu.org; Sat, 13 Dec 2008 06:40:09 -0500 Received: from [199.232.76.173] (port=35553 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBSqs-0004tC-Hp for qemu-devel@nongnu.org; Sat, 13 Dec 2008 06:40:06 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:47302) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBSqr-0004Tg-U3 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 06:40:06 -0500 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate03.web.de (Postfix) with ESMTP id 84261F560603 for ; Sat, 13 Dec 2008 12:40:04 +0100 (CET) Received: from [88.64.11.10] (helo=[192.168.1.198]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1LBSqq-0004iT-00 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 12:40:04 +0100 Message-ID: <49439EF3.2010009@web.de> Date: Sat, 13 Dec 2008 12:39:31 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <49437EF9.6000704@web.de> <494386C7.80703@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig69B450D7519E526F360C26D1" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [5998] Fix TARGET_LONG_BITS warning in TCG Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig69B450D7519E526F360C26D1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Blue Swirl wrote: > On 12/13/08, Jan Kiszka wrote: >> Blue Swirl wrote: >> > On 12/13/08, Jan Kiszka wrote: >> >> Blue Swirl wrote: >> >> > Revision: 5998 >> >> > http://svn.sv.gnu.org/viewvc/?view=3Drev&root=3Dqemu&= revision=3D5998 >> >> > Author: blueswir1 >> >> > Date: 2008-12-13 08:16:43 +0000 (Sat, 13 Dec 2008) >> >> > >> >> > Log Message: >> >> > ----------- >> >> > Fix TARGET_LONG_BITS warning in TCG >> >> > >> >> > Looking at tcg/tcg.c:828, the bug that the warning indicated wo= uld show up as >> >> > incorrect PC shown in log, only on 32 bit big endian host emula= ting a 64 bit >> >> > target, -d op flag enabled. Now that dyngen is gone, the patch = can be applied. >> >> > >> >> > Modified Paths: >> >> > -------------- >> >> > trunk/tcg/tcg-runtime.c >> >> > >> >> > Modified: trunk/tcg/tcg-runtime.c >> >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> > --- trunk/tcg/tcg-runtime.c 2008-12-12 20:02:52 UTC (rev 5997= ) >> >> > +++ trunk/tcg/tcg-runtime.c 2008-12-13 08:16:43 UTC (rev 5998= ) >> >> > @@ -29,6 +29,7 @@ >> >> > >> >> > #include "config.h" >> >> > #include "osdep.h" >> >> > +#include "cpu.h" // For TARGET_LONG_BITS >> >> > #include "tcg.h" >> >> > >> >> > int64_t tcg_helper_shl_i64(int64_t arg1, int64_t arg2) >> >> > >> >> >> >> >> >> Nice that this warning is finally fixed - but what is the point of= >> >> including all those headers at all here? [1] worked well for me w= hile >> >> reducing dependencies. >> > >> > I think all header files should be checked and even reorganized whe= n >> > necessary. One item is the dyngen removal, cpu.h/exec.h distinction= is >> > not clear for all targets and headers used by both user and system >> > emulators could be adjusted. Header files in hw should be OK, but >> > worth checking. >> >> >> Header dependencies and usage policies should be rechecked and probabl= y >> cleaned up now, no question (see also my dyngen-exec.h problems). >> >> But here I was referring to the need of this _particular_ C file for = any >> header except inttypes.h. Why including headers _here_ for no use? >=20 > I tested the apparently harmless patch, but it isn't OK. osdep.h, > qemu-log.h and tcg.h use FILE and size_t, and therefore we need at > least stdio.h. Those headers should be fixed, then the patch would > work. >=20 Sorry, confused: Which patch for which file do you mean now? If you refer to mine: Why do we need osdep.h, qemu-log.h or tcg.h for tcg-runtime.c? Jan --------------enig69B450D7519E526F360C26D1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAklDnvkACgkQniDOoMHTA+kN0wCfWjX/0Mt5TONQpXdQNi9ALOt5 uyYAn2Z8IS7ZVqO5PUOfQrNdUqKFfrCU =eOQ0 -----END PGP SIGNATURE----- --------------enig69B450D7519E526F360C26D1--