From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBTuB-0003b7-45 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 07:47:35 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBTu8-0003aJ-Nw for qemu-devel@nongnu.org; Sat, 13 Dec 2008 07:47:33 -0500 Received: from [199.232.76.173] (port=36719 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBTu7-0003a1-LA for qemu-devel@nongnu.org; Sat, 13 Dec 2008 07:47:32 -0500 Received: from fmmailgate03.web.de ([217.72.192.234]:58138) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LBTu7-0002V0-1o for qemu-devel@nongnu.org; Sat, 13 Dec 2008 07:47:31 -0500 Received: from smtp06.web.de (fmsmtp06.dlan.cinetic.de [172.20.5.172]) by fmmailgate03.web.de (Postfix) with ESMTP id A1E23F560A81 for ; Sat, 13 Dec 2008 13:47:29 +0100 (CET) Received: from [88.64.11.10] (helo=[192.168.1.198]) by smtp06.web.de with asmtp (TLSv1:AES256-SHA:256) (WEB.DE 4.109 #226) id 1LBTu5-0003y9-00 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 13:47:29 +0100 Message-ID: <4943AEC0.60600@web.de> Date: Sat, 13 Dec 2008 13:46:56 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <49437EF9.6000704@web.de> <494386C7.80703@web.de> <49439EF3.2010009@web.de> In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4D6CB0849901257AA29DACE1" Sender: jan.kiszka@web.de Subject: [Qemu-devel] Re: [5998] Fix TARGET_LONG_BITS warning in TCG Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4D6CB0849901257AA29DACE1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Blue Swirl wrote: > On 12/13/08, Jan Kiszka wrote: >> Blue Swirl wrote: >> > On 12/13/08, Jan Kiszka wrote: >> >> Blue Swirl wrote: >> >> > On 12/13/08, Jan Kiszka wrote: >> >> >> Blue Swirl wrote: >> >> >> > Revision: 5998 >> >> >> > http://svn.sv.gnu.org/viewvc/?view=3Drev&root=3Dq= emu&revision=3D5998 >> >> >> > Author: blueswir1 >> >> >> > Date: 2008-12-13 08:16:43 +0000 (Sat, 13 Dec 2008) >> >> >> > >> >> >> > Log Message: >> >> >> > ----------- >> >> >> > Fix TARGET_LONG_BITS warning in TCG >> >> >> > >> >> >> > Looking at tcg/tcg.c:828, the bug that the warning indicate= d would show up as >> >> >> > incorrect PC shown in log, only on 32 bit big endian host e= mulating a 64 bit >> >> >> > target, -d op flag enabled. Now that dyngen is gone, the pa= tch can be applied. >> >> >> > >> >> >> > Modified Paths: >> >> >> > -------------- >> >> >> > trunk/tcg/tcg-runtime.c >> >> >> > >> >> >> > Modified: trunk/tcg/tcg-runtime.c >> >> >> > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D >> >> >> > --- trunk/tcg/tcg-runtime.c 2008-12-12 20:02:52 UTC (rev = 5997) >> >> >> > +++ trunk/tcg/tcg-runtime.c 2008-12-13 08:16:43 UTC (rev = 5998) >> >> >> > @@ -29,6 +29,7 @@ >> >> >> > >> >> >> > #include "config.h" >> >> >> > #include "osdep.h" >> >> >> > +#include "cpu.h" // For TARGET_LONG_BITS >> >> >> > #include "tcg.h" >> >> >> > >> >> >> > int64_t tcg_helper_shl_i64(int64_t arg1, int64_t arg2) >> >> >> > >> >> >> >> >> >> >> >> >> Nice that this warning is finally fixed - but what is the poin= t of >> >> >> including all those headers at all here? [1] worked well for = me while >> >> >> reducing dependencies. >> >> > >> >> > I think all header files should be checked and even reorganized= when >> >> > necessary. One item is the dyngen removal, cpu.h/exec.h distinc= tion is >> >> > not clear for all targets and headers used by both user and sys= tem >> >> > emulators could be adjusted. Header files in hw should be OK, b= ut >> >> > worth checking. >> >> >> >> >> >> Header dependencies and usage policies should be rechecked and pro= bably >> >> cleaned up now, no question (see also my dyngen-exec.h problems).= >> >> >> >> But here I was referring to the need of this _particular_ C file = for any >> >> header except inttypes.h. Why including headers _here_ for no use= ? >> > >> > I tested the apparently harmless patch, but it isn't OK. osdep.h, >> > qemu-log.h and tcg.h use FILE and size_t, and therefore we need at >> > least stdio.h. Those headers should be fixed, then the patch would >> > work. >> > >> >> >> Sorry, confused: Which patch for which file do you mean now? If you >> refer to mine: Why do we need osdep.h, qemu-log.h or tcg.h for >> tcg-runtime.c? >=20 > This one: > http://permalink.gmane.org/gmane.comp.emulators.qemu/32076 >=20 > They are not needed, but pulled in as a side product. >=20 OK, finally got it: we want prototypes for non-static functions now, and therefore we need tcg/tcg.h and all what comes with it. Jan --------------enig4D6CB0849901257AA29DACE1 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org iEYEARECAAYFAklDrsUACgkQniDOoMHTA+kfJwCfV3dg8yADmQZ/S8JYUfYqceQx qrsAn1Bpyh7sST2B2HEMH97fDYpD3w7E =/OgT -----END PGP SIGNATURE----- --------------enig4D6CB0849901257AA29DACE1--