From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LBdkd-0005gn-2X for qemu-devel@nongnu.org; Sat, 13 Dec 2008 18:18:23 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LBdkc-0005fk-58 for qemu-devel@nongnu.org; Sat, 13 Dec 2008 18:18:22 -0500 Received: from [199.232.76.173] (port=51977 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LBdkb-0005fe-Tf for qemu-devel@nongnu.org; Sat, 13 Dec 2008 18:18:21 -0500 Received: from outbound-wa4.frontbridge.com ([216.32.181.16]:49113 helo=WA4EHSOBE003.bigfish.com) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_ARCFOUR_MD5:16) (Exim 4.60) (envelope-from ) id 1LBdkb-00035f-JQ for qemu-devel@nongnu.org; Sat, 13 Dec 2008 18:18:21 -0500 Message-ID: <4943EE6C.8030508@amd.com> Date: Sat, 13 Dec 2008 18:18:36 +0100 From: Andre Przywara MIME-Version: 1.0 References: <4940F9B5.9080206@amd.com> <49427CE1.4050108@codemonkey.ws> <49438371.9060304@redhat.com> In-Reply-To: <49438371.9060304@redhat.com> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH 2/3] NUMA: promoting NUMA topology to BIOS and pin guest memory Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org Avi Kivity wrote: > Anthony Liguori wrote: >> >> At this point, I'm okay with introducing the libnuma dependency for >> memory pinning. I'm not sure I think we should even present this as a >> command line option though. I think the command line option should >> just specify the NUMA topology and then we should use a monitor >> command for pinning (as you do on your next patch). > > It's helpful to have static pinning from the command line. That's > useful for quick tests for those of us who don't use management interfaces. > > Since the monitor and command line can share code, there shouldn't be > any cost to this. ACK. Actually I'd had to add code to prevent pinning from the command line. I think this doesn't hurt, if you use virtualization for partitioning (where a NUMA architecture can actually help you, because guests don't compete will all other guests for the memory bandwidth), it is quite helpful to specify everything at the beginning. Here even UP guest can take advantage: -numa 1,pin:1 Regards, Andre. -- Andre Przywara AMD-Operating System Research Center (OSRC), Dresden, Germany Tel: +49 351 277-84917 ----to satisfy European Law for business letters: AMD Saxony Limited Liability Company & Co. KG, Wilschdorfer Landstr. 101, 01109 Dresden, Germany Register Court Dresden: HRA 4896, General Partner authorized to represent: AMD Saxony LLC (Wilmington, Delaware, US) General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy