qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Thomas Huth <huth@tuxfamily.org>, qemu-devel@nongnu.org
Cc: Natalia Portillo <claunia@claunia.com>,
	Laurent Vivier <laurent@vivier.eu>,
	Bryce Lanham <blanham@gmail.com>
Subject: Re: [Qemu-devel] [PATCH v1 1/4] m68k: Add NeXTcube framebuffer device emulation
Date: Sat, 30 Jun 2018 09:00:46 -0700	[thread overview]
Message-ID: <49444120-add0-17fe-5e57-2d195be5d3ed@linaro.org> (raw)
In-Reply-To: <20180630083357.23489-2-huth@tuxfamily.org>

On 06/30/2018 01:33 AM, Thomas Huth wrote:
> +    uint32_t pal[4] = { 0xFFFFFFFF, 0xFFAAAAAA, 0xFF555555, 0xFF000000 };

static const.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~

  reply	other threads:[~2018-06-30 16:00 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-30  8:33 [Qemu-devel] [PATCH v1 0/4] m68k: Add basic support for the NeXTcube machine Thomas Huth
2018-06-30  8:33 ` [Qemu-devel] [PATCH v1 1/4] m68k: Add NeXTcube framebuffer device emulation Thomas Huth
2018-06-30 16:00   ` Richard Henderson [this message]
2018-06-30 16:12   ` Peter Maydell
2018-06-30 19:47     ` Thomas Huth
2018-06-30 20:06       ` Peter Maydell
2018-06-30  8:33 ` [Qemu-devel] [PATCH v1 2/4] m68k: Add NeXTcube keyboard device Thomas Huth
2018-06-30 16:18   ` Peter Maydell
2018-06-30  8:33 ` [Qemu-devel] [PATCH v1 4/4] m68k: Add an entry for the NeXTcube machine to the MAINTAINERS file Thomas Huth
2018-06-30  9:42 ` [Qemu-devel] [PATCH v1 0/4] m68k: Add basic support for the NeXTcube machine Mark Cave-Ayland
2018-06-30 13:14   ` Thomas Huth
2018-06-30 13:17     ` Peter Maydell
2018-06-30 13:34       ` Thomas Huth
2018-06-30 17:07         ` Bryce Lanham
2018-06-30 20:09           ` Thomas Huth
2018-07-03 20:58           ` Natalia Portillo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49444120-add0-17fe-5e57-2d195be5d3ed@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=blanham@gmail.com \
    --cc=claunia@claunia.com \
    --cc=huth@tuxfamily.org \
    --cc=laurent@vivier.eu \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).