From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LCbMA-0007VG-Hb
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 09:57:06 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LCbM9-0007U3-1Z
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 09:57:05 -0500
Received: from [199.232.76.173] (port=41729 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LCbM8-0007Tt-No
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 09:57:04 -0500
Received: from yw-out-1718.google.com ([74.125.46.157]:48115)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LCbM8-00064o-Ca
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 09:57:04 -0500
Received: by yw-out-1718.google.com with SMTP id 6so1465109ywa.82
	for <qemu-devel@nongnu.org>; Tue, 16 Dec 2008 06:57:03 -0800 (PST)
Message-ID: <4947C1BB.2060202@codemonkey.ws>
Date: Tue, 16 Dec 2008 08:56:59 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Time drift again.
References: <20081216122511.GE13794@redhat.com>
In-Reply-To: <20081216122511.GE13794@redhat.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gleb Natapov wrote:
> +
>  RTCState *rtc_init(int base, qemu_irq irq)
>  {
>      RTCState *s;
> @@ -483,6 +532,9 @@ RTCState *rtc_init(int base, qemu_irq irq)
>      register_ioport_read(base, 2, 1, cmos_ioport_read, s);
>  
>      register_savevm("mc146818rtc", base, 1, rtc_save, rtc_load, s);
> +#ifdef TARGET_I386
> +    register_savevm("mc146818rtc-td", base, 1, rtc_save_td, rtc_load_td, s);
> +#endif
>   

This should be conditional on whether TDF is enabled or not (these 
fields are meaningless if it's not enabled).

Modulo documentation, I think this patch is just about the best we can 
do.  I'm inclined to commit this once you've sent out an updated patch 
unless anyone has major objections.

Regards,

Anthony Liguori