From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LCgWz-0003j3-9X for qemu-devel@nongnu.org; Tue, 16 Dec 2008 15:28:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LCgWx-0003ii-8W for qemu-devel@nongnu.org; Tue, 16 Dec 2008 15:28:36 -0500 Received: from [199.232.76.173] (port=56321 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LCgWx-0003if-5b for qemu-devel@nongnu.org; Tue, 16 Dec 2008 15:28:35 -0500 Received: from qw-out-1920.google.com ([74.125.92.147]:14965) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LCgWw-0004nC-S3 for qemu-devel@nongnu.org; Tue, 16 Dec 2008 15:28:35 -0500 Received: by qw-out-1920.google.com with SMTP id 5so803487qwc.4 for ; Tue, 16 Dec 2008 12:28:34 -0800 (PST) Message-ID: <49480F6D.2010302@codemonkey.ws> Date: Tue, 16 Dec 2008 14:28:29 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 0/3] Add BIOS splash image support References: <1229440810-12394-1-git-send-email-Laurent.Vivier@bull.net> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: bochs developers , qemu-devel@nongnu.org, kvm developers Blue Swirl wrote: > On 12/16/08, Laurent Vivier wrote: > >> This series of patches adds a nice BIOS startup splash screen. >> >> It adds a "-splash" option allowing to specify the picture file name (a 640x480 (or less) and true color PNG) to display. You can enable/disable fade in, >> fade out and bootmenu. The time to display the image can be also given (in >> seconds). >> >> Idea and some parts of code are stollen from VirtualBox (GPLv2/CDDL). >> >> [PATCH 1/3] Correct fw_cfg_add_callback() >> [PATCH 2/3] [BIOS] Add splash image support >> [PATCH 3/3] [QEMU] Add BIOS splash image >> > > On second thought, there is no Gtk/Qt GUI because that is supposed to > be external to Qemu. By the same logic, why should there be any splash > screen? The external GUI can probably show it as easily using the same > Gtk/Qt/whatever. You need it to be consistent on the SDL/VNC display. Modern BIOSes have splash screens. I don't see why our BIOS shouldn't have one too. > The control channel may still be needed. > > Alternatively the BIOS could load the image and fade parameters from a > new ROM or from the configuration device and draw it to screen. This > would need some PNG support to BIOS, or that the image stored in raw > form. > Yeah, having QEMU render to the VGA directly is a bit ugly. It would be nicer if the BIOS actually rendered the image but I'm not sure I think we should reject the patch just because it doesn't. Regards, Anthony Liguori > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >