From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LChHR-0001Cb-I2
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 16:16:37 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LChHP-0001C5-IP
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 16:16:36 -0500
Received: from [199.232.76.173] (port=60632 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LChHP-0001By-BH
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 16:16:35 -0500
Received: from yw-out-1718.google.com ([74.125.46.153]:30836)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LChHP-0004SL-7E
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 16:16:35 -0500
Received: by yw-out-1718.google.com with SMTP id 6so1550814ywa.82
	for <qemu-devel@nongnu.org>; Tue, 16 Dec 2008 13:16:34 -0800 (PST)
Message-ID: <49481AAD.5060501@codemonkey.ws>
Date: Tue, 16 Dec 2008 15:16:29 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4947B819.9090307@amd.com>
In-Reply-To: <4947B819.9090307@amd.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 3/8] v2: add info numa monitor command
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andre Przywara <andre.przywara@amd.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Andre Przywara wrote:
> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
>
> # HG changeset patch
> # User Andre Przywara <andre.przywara@amd.com>
> # Date 1229430525 -3600
> # Node ID 0f3054b66373c2a8b65a5be6d83af63f807dd88f
> # Parent  a0a2e3026d4acffdce91b776d8c2d733767693c5
> add info numa command to the monitor
>
> diff -r a0a2e3026d4a -r 0f3054b66373 monitor.c
> --- a/monitor.c	Tue Dec 16 13:28:24 2008 +0100
> +++ b/monitor.c	Tue Dec 16 13:28:45 2008 +0100
> @@ -1281,6 +1281,20 @@ static void do_info_kvm(void)
>  #endif
>  }
>  
> +static void do_info_numa(void)
> +{
> +    int i, j;
> +
> +    term_printf("%d nodes\n", numnumanodes);
> +    for (i = 0; i < numnumanodes; i++) {
> +        term_printf("node %d cpus:", i);
> +        for (j = 0; j < 64; j++)
> +            if (node_to_cpus[i] & (1ULL << j)) term_printf(" %d", j);
>   

So the current code limits us to 64-cpus?  That's a pretty serious 
limitation IMHO.  I think that strongly suggests we're using the wrong 
structures for node_to_cpus--especially to be in the BIOS FW interface.

Regards,

Anthony Liguori