[Qemu-devel] Re: [PATCH 4/8] v2: extend parser to parse pin: option

[Andre Przywara <andre.przywara@amd.com>]

Anthony Liguori wrote:
> Andre Przywara wrote:
>> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
>>
> 
> I think we suggested that this should be specified in a different option 
> than -numa to separate the host/guest configuration bits.
As I said in the beginning of 0/8, I don't think that makes much sense.
Do you want this to be independent of the rest of NUMA (guest) code? 
Then this is a different story.
The purpose of this code is to pin _multiple_ guest nodes to _multiple_ 
different host nodes, something that is quite intricate to do otherwise.

In a single node case you can easily use numactl (or whatever your OS 
provides). If you want to use this NUMA code on a single node guest 
anyway, you can easily say: "-numa 1,pin:2" or "-numa 1 -numa pin:2".

Separating this pinning part out of the whole NUMA guest code will 
increase code complexity and IMHO is not justified, as OS provided 
methods are more portable for the single node case (currently this 
pinning is Linux only, which is backed by the original KVM target).

I suppose -pin is too ambiguous, also you pin it to nodes, so something 
like -nodepin or -numapin would suggest itself. I just insert a space to 
the latter.

Please tell me your opinion (and maybe a concrete suggestion on which 
syntax to use).

Regards,
Andre.

P.S. Do you agree to Avi that the colon should be substituted by an 
equal-sign?

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy