From: Andre Przywara <andre.przywara@amd.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 1/8] v2: introduce -numa command line option
Date: Wed, 17 Dec 2008 00:31:48 +0100 [thread overview]
Message-ID: <49483A64.3040607@amd.com> (raw)
In-Reply-To: <49481A15.6080402@codemonkey.ws>
Anthony Liguori wrote:
>> + if (i == numnumanodes) {
>> + for (i = 0; i < smp_cpus; i++)
>> + node_to_cpus[i % numnumanodes] |= 1<<i;
>>
>
> The way CPUs are allocate here seems strange? Each CPU is assigned
> round robin? Should you have node 0 contain 1..X, node 1 contain X..Y,
> node 2 contain Y..smp_cpus?
This is because an algorithm to do it this way is more complicated than
this round-robin scheme (imagine distributing 8 CPUs over 3 nodes).
Actually I know machines which do this natively (probably for the same
reason, code simplicity in the BIOS). OSes can cope with my variant too,
there is no guarantee that sequentially numbered CPUs belong to one node.
But if you insist, I fix it.
Regards,
Andre.
--
Andre Przywara
AMD-OSRC (Dresden)
Tel: x84917
next prev parent reply other threads:[~2008-12-16 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-16 14:13 [Qemu-devel] [PATCH 1/8] v2: introduce -numa command line option Andre Przywara
2008-12-16 21:13 ` [Qemu-devel] " Anthony Liguori
2008-12-16 23:31 ` Andre Przywara [this message]
2008-12-17 0:05 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49483A64.3040607@amd.com \
--to=andre.przywara@amd.com \
--cc=anthony@codemonkey.ws \
--cc=avi@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).