qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@amd.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 3/8] v2: add info numa monitor command
Date: Wed, 17 Dec 2008 00:52:54 +0100	[thread overview]
Message-ID: <49483F56.7020703@amd.com> (raw)
In-Reply-To: <49481AAD.5060501@codemonkey.ws>

Anthony Liguori wrote:

> So the current code limits us to 64-cpus?  That's a pretty serious 
> limitation IMHO.
I know, but I was hoping that a simpler patch would be easier to merge. 
So I am happy to fix it later and lift this restriction.
I searched for some kind of variable length bitmap type (like Linux' 
cpu_set_t) already being used in QEMU, but couldn't find anything 
appropriate. Do you know something? If you look at the glibc cpu_set_t 
implementation (in bits/sched.h), you surely want to make this a 
separate patch.

> I think that strongly suggests we're using the wrong 
> structures for node_to_cpus--especially to be in the BIOS FW interface.
Ok, this could be a point, but is this BIOS FW interface really a stable 
interface we cannot change later easily? IMHO this is QEMU (and derived 
projects) only, which always provide a matching BIOS anyway.

What about if I prepare the BIOS FW interface for future expansion and 
stick to the current uint64_t type for now?

Regards,
Andre.

And by the way: 64 core machines are _not_ common today, especially not 
when hosting pure QEMU :-)

-- 
Andre Przywara
AMD-Operating System Research Center (OSRC), Dresden, Germany
Tel: +49 351 277-84917
----to satisfy European Law for business letters:
AMD Saxony Limited Liability Company & Co. KG,
Wilschdorfer Landstr. 101, 01109 Dresden, Germany
Register Court Dresden: HRA 4896, General Partner authorized
to represent: AMD Saxony LLC (Wilmington, Delaware, US)
General Manager of AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy

  reply	other threads:[~2008-12-16 23:53 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-16 14:15 [Qemu-devel] [PATCH 3/8] v2: add info numa monitor command Andre Przywara
2008-12-16 21:16 ` [Qemu-devel] " Anthony Liguori
2008-12-16 23:52   ` Andre Przywara [this message]
2008-12-17  0:11     ` Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49483F56.7020703@amd.com \
    --to=andre.przywara@amd.com \
    --cc=anthony@codemonkey.ws \
    --cc=avi@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).