From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LCk8O-0006xf-Us
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 19:19:29 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LCk8M-0006uH-4F
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 19:19:27 -0500
Received: from [199.232.76.173] (port=44930 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LCk8L-0006u6-Ss
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 19:19:25 -0500
Received: from yx-out-1718.google.com ([74.125.44.154]:6599)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LCk8L-0005ig-Is
	for qemu-devel@nongnu.org; Tue, 16 Dec 2008 19:19:25 -0500
Received: by yx-out-1718.google.com with SMTP id 3so1580238yxi.82
	for <qemu-devel@nongnu.org>; Tue, 16 Dec 2008 16:19:25 -0800 (PST)
Message-ID: <49484586.7060106@codemonkey.ws>
Date: Tue, 16 Dec 2008 18:19:18 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <4947B863.1040909@amd.com> <49481AEB.1020909@codemonkey.ws>
	<494838F1.6070005@amd.com>
In-Reply-To: <494838F1.6070005@amd.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH 4/8] v2: extend parser to parse pin: option
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andre Przywara <andre.przywara@amd.com>
Cc: qemu-devel@nongnu.org, Avi Kivity <avi@redhat.com>

Andre Przywara wrote:
> Anthony Liguori wrote:
>> Andre Przywara wrote:
>>> Signed-off-by: Andre Przywara <andre.przywara@amd.com>
>>>
>>
>> I think we suggested that this should be specified in a different 
>> option than -numa to separate the host/guest configuration bits.
> As I said in the beginning of 0/8, I don't think that makes much sense.
> Do you want this to be independent of the rest of NUMA (guest) code? 
> Then this is a different story.

I'm not sure I see what you're asking.

> The purpose of this code is to pin _multiple_ guest nodes to 
> _multiple_ different host nodes, something that is quite intricate to 
> do otherwise.

Right now, you say:

-numa 2,mem:1G;2G,cpu:0-1;2-3,pin:2;3

My most preferred syntax would be:

-numa node,mem=0G-1G,cpu=0-1,nodeid=0 -numa pin,nodeid=0,hostid=2 \
-numa node,mem=1G-3G,cpu=2-3,nodeid=1 -numa pin,nodeid=1,hostid=3

It's more typing, but it maps really well to how -net tap works and how 
-drive works.  It has a lot less special characters too.  I'm not saying 
this is the only right solution, but this is probably what I would do if 
I were writing this.
>
> Please tell me your opinion (and maybe a concrete suggestion on which 
> syntax to use).
>
> Regards,
> Andre.
>
> P.S. Do you agree to Avi that the colon should be substituted by an 
> equal-sign?
>

Yes.

Regards,

Anthony Liguori