qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: John Haxby <john.haxby@oracle.com>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] configure echo usage
Date: Wed, 17 Dec 2008 09:32:17 +0000	[thread overview]
Message-ID: <4948C721.2060507@oracle.com> (raw)
In-Reply-To: <5ED905FB-CB4B-45D3-99B7-3D415750F2C4@sonous.com>

Lev Lvovsky wrote:
>
> bash-3.2$ svn diff configure
> Index: configure
> ===================================================================
> --- configure   (revision 6069)
> +++ configure   (working copy)
> @@ -1094,8 +1094,7 @@
>  test -f $config_h && mv $config_h ${config_h}~
>
>  echo "# Automatically generated by configure - do not modify" > 
> $config_mak
> -echo -n "# Configured with:" >> $config_mak
> -printf " '%s'" "$0" "$@" >> $config_mak
> +printf "# Configured with: $0 $@" >> $config_mak
>  echo >> $config_mak
>  echo "/* Automatically generated by configure - do not modify */" > 
> $config_h
>
>
>


That doesn't give the same output: the original puts each of $0 and the 
$@'s with single quotes around them in the config file, yours misses out 
the quotes.   Replacing the original echo -n, printf and echo like this 
would work though:

    echo "# Configured with:$(printf " '%s'" "$0" "$@")" >> $config_mak

If the OS X shell doesn't do $(...) then this will work, albeit at the 
cost of readabilty

    echo "# Configured with:"`printf " '%s'" "$0" "$@"` >> $config_mak

(those pesky backquotes are harder to see and for the ultra-picky it's 
not quite the same thing).

jch

  reply	other threads:[~2008-12-17  9:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-17  7:24 [Qemu-devel] configure echo usage Lev Lvovsky
2008-12-17  9:32 ` John Haxby [this message]
2008-12-17  9:46   ` Andreas Schwab
2008-12-17 10:34     ` John Haxby
2008-12-17 17:15   ` Lev Lvovsky
     [not found]     ` <4510F100-F900-4CAF-8269-7721B6FA3001@hotmail.com>
2008-12-18  4:46       ` C.W. Betts
2008-12-18  5:23         ` Lev Lvovsky

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4948C721.2060507@oracle.com \
    --to=john.haxby@oracle.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).