From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LCw1u-0007aW-TO for qemu-devel@nongnu.org; Wed, 17 Dec 2008 08:01:34 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LCw1t-0007ZA-GB for qemu-devel@nongnu.org; Wed, 17 Dec 2008 08:01:34 -0500 Received: from [199.232.76.173] (port=43449 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LCw1s-0007Yu-M6 for qemu-devel@nongnu.org; Wed, 17 Dec 2008 08:01:32 -0500 Received: from ns.suse.de ([195.135.220.2]:49717 helo=mx1.suse.de) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LCw1s-0003iE-7F for qemu-devel@nongnu.org; Wed, 17 Dec 2008 08:01:32 -0500 Message-ID: <4948F944.7010900@suse.de> Date: Wed, 17 Dec 2008 14:06:12 +0100 From: Kevin Wolf MIME-Version: 1.0 Subject: Re: [Qemu-devel] [5860] Cleanup {alloc|get}_cluster_offset() (Gleb Natapov) References: <493FD45B.5010500@codemonkey.ws> <20081211110056.GJ5555@redhat.com> <20081211183258.fqitybgdw8gwgocs@imap.suse.de> In-Reply-To: <20081211183258.fqitybgdw8gwgocs@imap.suse.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gleb Natapov Kevin Wolf schrieb: > Am Do 11 Dez 2008 12:00:56 CET schrieb Gleb Natapov : > >> On Wed, Dec 10, 2008 at 08:38:19AM -0600, Anthony Liguori wrote: >>> Hi Gleb, >>> >>> Anthony Liguori wrote: >>>> Revision: 5860 >>>> >>>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=5860 >>>> Author: aliguori >>>> Date: 2008-12-02 20:11:27 +0000 (Tue, 02 Dec 2008) >>>> >>> >>> According to https://bugzilla.novell.com/show_bug.cgi?id=457957, this >>> changeset breaks compressed qcow2 on write and savevm. >>> >>> Can you please look into this? >>> >> Alexander, can you try the patch below? > > Hm, no signed-off line yet. Anyway: > > Acked-by: Kevin Wolf Anthony, care to apply Gleb's patch? It doesn't seem to be committed yet. Kevin