Re: [Qemu-devel] [PATCH] x86: Manage BIOS boot menu via command line

[Anthony Liguori <anthony@codemonkey.ws>]

> diff --git a/pc-bios/bios-pq/0006_optional-boot-menu.patch b/pc-bios/bios-pq/0006_optional-boot-menu.patch
> new file mode 100644
> index 0000000..bbe5753
> --- /dev/null
> +++ b/pc-bios/bios-pq/0006_optional-boot-menu.patch
> @@ -0,0 +1,19 @@
> +Make interactive boot menu optional.
> +
> +Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
> +
> +diff --git a/bios/rombios.c b/bios/rombios.c
> +index 123672f..7ce5b6c 100644
> +--- a/bios/rombios.c
> ++++ b/bios/rombios.c
> +@@ -2026,6 +2026,10 @@ interactive_bootkey()
> +   Bit16u ss = get_SS();
> +   Bit16u valid_choice = 0;
> + 
> ++  /* QEMU sets CMOS byte 0x60 to non-zero if the boot menu should be skipped */
> ++  if (inb_cmos(0x60))
> ++    return;
> ++
>   

Should we be using firmware config for this?

I think I'd still like to see BIOS patches submitted as separate 
patches.  We'll take care of updating the series file and sticking them 
into the right place.  Diffs of diffs are pretty hard for me to read :-)

Regards,

Anthony Liguori