From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LDmKM-0003TI-0R for qemu-devel@nongnu.org; Fri, 19 Dec 2008 15:52:06 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LDmKK-0003SA-KB for qemu-devel@nongnu.org; Fri, 19 Dec 2008 15:52:05 -0500 Received: from [199.232.76.173] (port=37299 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LDmKK-0003Rw-B4 for qemu-devel@nongnu.org; Fri, 19 Dec 2008 15:52:04 -0500 Received: from rn-out-0910.google.com ([64.233.170.188]:21658) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LDmKJ-0003WI-Vp for qemu-devel@nongnu.org; Fri, 19 Dec 2008 15:52:04 -0500 Received: by rn-out-0910.google.com with SMTP id 56so834780rnw.8 for ; Fri, 19 Dec 2008 12:52:02 -0800 (PST) Message-ID: <494C096D.1050902@codemonkey.ws> Date: Fri, 19 Dec 2008 14:51:57 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 5/6] hook cpu_register_physical_mem References: <1229619702-26315-1-git-send-email-glommer@redhat.com> <1229619702-26315-2-git-send-email-glommer@redhat.com> <1229619702-26315-3-git-send-email-glommer@redhat.com> <1229619702-26315-4-git-send-email-glommer@redhat.com> <1229619702-26315-5-git-send-email-glommer@redhat.com> <1229619702-26315-6-git-send-email-glommer@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Blue Swirl Cc: stefano.stabellini@eu.citrix.com, Ian.Jackson@eu.citrix.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, avi@redhat.com Blue Swirl wrote: > On 12/18/08, Glauber Costa wrote: > >> Since now we have our own memory read/write function, we don't >> depend on all of tcg data structures anymore. So, instead of filling >> them up, bypass it altogether by using kvm_set_phys mem alone. >> >> To do that, we now have to provide our own way to get page >> information given the address. (kvm_get_physical_page_desc) >> >> Signed-off-by: Glauber Costa >> > > >> +static void tcg_register_physical_memory_offset(target_phys_addr_t start_addr, >> > > I don't think TCG actually has much to do with the function. It really does though. The way physical memory is registered and managed is TCG specific right now. It has deep hooks for invalidating TranslationBlock's, and the table structure is designed to be conducive to the access patterns of TCG. If you think of a higher level CPU API, I think registering physical memory and reading/writing physical memory would end up being part of that API. Regards, Anthony Liguori > Would > no_kvm be too ugly? > > More philosophically, what is (Qemu /\ ~KVM /\ ~TCG)? I hope I got the > math right. > -- > To unsubscribe from this list: send the line "unsubscribe kvm" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html >