Re: [Qemu-devel] [PATCH] add missing firmware configuration channel numbers to BIOS

[Andre Przywara <andre.przywara@amd.com>]

Blue Swirl wrote:
>>
>>  although we currently don't use firmware config channel
>>  numbers higher than '0x02' in the PC-BIOS, add the channel
>>  names to the BIOS source to mark already used entries.
>>  This will make picking new number easier in the future.
> 
> Isn't it possible to use fw_cfg.h directly? To get just the constants,
> you can use NO_QEMU_PROTOS.
Nice idea, but this would require to have the QEMU sources directly 
available when building the BIOS ROM. This is not a real problem, but 
would require to pull in the QEMU source path from the BOCHS autotools 
Makefile (with what default? Revert to the current code if no QEMU 
source path is given?). Currently you can build the BIOS independently 
with just the QEMU patches applied. If you (or Anthony) think this OK, 
I'd prepare a patch for this.

Regards,
Andre.

> 
> This is how it is used in OpenBIOS/Sparc64 as an example:
> 
> http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/arch/sparc64/entry.S#L14
> 
> http://tracker.coreboot.org/trac/openbios/browser/openbios-devel/arch/sparc64/openbios.c#L29
>