From: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
To: qemu-devel@nongnu.org
Cc: theburner1@yahoo.com
Subject: Re: [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack
Date: Tue, 23 Dec 2008 20:43:24 +0100 [thread overview]
Message-ID: <49513F5C.1010605@gmx.net> (raw)
In-Reply-To: <f43fc5580812231030n7319faedu420bf408004b221a@mail.gmail.com>
On 23.12.2008 19:30, Blue Swirl wrote:
> On 12/23/08, Justin Chevrier <theburner1@yahoo.com> wrote:
>
>> It also appears that the code referenced in the link loops infinitely due to a missing: "max_sensei--;" which is present in the Linux Kernel's equivalent code.
>>
>
> This one:
> http://fxr.watson.org/fxr/source/drivers/block/floppy.c?v=linux-2.4.22;im=bigexcerpts#L1800
>
> Adding max_sensei-- to OpenBIOS allows it to survive your previous
> patch, which caused an infinite loop earlier:
>
> floppy_motor_off
> SENSEI c0 00
> SENSEI c0 00
> SENSEI c0 00
> SENSEI c0 00
> status = 80, reply_buffer= c0 0
>
Can you send a patch for this issue to upstream OpenBIOS?
Thanks!
Regards,
Carl-Daniel
--
http://www.hailfinger.org/
next prev parent reply other threads:[~2008-12-23 19:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-23 18:02 [Qemu-devel] [PATCH] Floppy: Remove Sense Interrupt Hack Justin Chevrier
2008-12-23 18:13 ` Blue Swirl
2008-12-23 18:30 ` Blue Swirl
2008-12-23 19:43 ` Carl-Daniel Hailfinger [this message]
2008-12-23 19:58 ` Blue Swirl
2008-12-23 21:46 ` Carl-Daniel Hailfinger
-- strict thread matches above, loose matches on Subject: below --
2008-12-23 18:13 Justin Chevrier
2008-12-18 21:14 Justin Chevrier
2008-12-19 19:43 ` Blue Swirl
2008-12-19 21:41 ` Justin Chevrier
2008-12-20 10:54 ` Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49513F5C.1010605@gmx.net \
--to=c-d.hailfinger.devel.2006@gmx.net \
--cc=qemu-devel@nongnu.org \
--cc=theburner1@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).