qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: turnkey-discuss@lists.turnkeylinux.org,
	Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] Merging improvements from VirtualBox OSE into qemu?
Date: Wed, 24 Dec 2008 09:40:56 -0600	[thread overview]
Message-ID: <49525808.9080002@codemonkey.ws> (raw)
In-Reply-To: <4952484F.6010406@turnkeylinux.org>

Liraz Siri wrote:
> Paul Brook wrote:
>
>   
>> You need root privileges to load the random kernel modules required to d this. 
>> Not going to happen for qemu.
>>     
>
> There's at least one counter-precedent. qemu takes advantage of kqemu
> which is also a "random kernel module". How would supporting a kernel
> module that simplified a bridged networking be any different?
>   

I would object strongly to any new code in QEMU that was relying on a 
kernel module that had no chance of making it upstream.

FWIW, we could simplify bridged networking in QEMU but it would require 
root privileges or a setuid helper.

All someone has to do is write an /etc/qemu-ifup and /etc/qemu-ifdown 
that create a bridged interface.  I'd be happy to take patches to pass 
additional parameters to the script.  For instance, you could do:

-net tap,mode=bridging,if=eth0

And it could Just Work.  /etc/qemu-ifup and /etc/qemu-ifdown would have 
to be setuid helpers of course and they should enforce some sort of 
group access control.

> Also, qemu seems to require root privileges to setup tap devices, so it
> wouldn't be a first.
>   

It does, but there's no reason we could extend tap just a little bit so 
that it got a file descriptor from the /etc/qemu-ifup script.

> BTW, we don't need this for our own use. We setup VDE + tap devices
> bridged to the network interface. Works great, at least for NICs that
> support bridging.

AFAIK, VDE doesn't actually get a tap file descriptor.  Instead it sends 
all traffic to a daemon for processing.  This implies that performance 
will never be as good as tap.

Regards,

Anthony Liguori

  parent reply	other threads:[~2008-12-24 15:41 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-12-24 12:48 [Qemu-devel] Merging improvements from VirtualBox OSE into qemu? Liraz Siri
2008-12-24 13:17 ` Samuel Thibault
2008-12-24 13:26   ` Alexey Eremenko
2008-12-24 13:31 ` Alexey Eremenko
2008-12-24 13:36 ` Paul Brook
2008-12-24 14:33   ` Liraz Siri
2008-12-24 14:51     ` Jernej Simončič
2008-12-24 15:02     ` Paul Brook
2008-12-24 15:29       ` Liraz Siri
2008-12-24 15:40     ` Anthony Liguori [this message]
2008-12-24 20:52       ` Liraz Siri
     [not found]     ` <E71DFB2B-0B73-46AE-B423-0BF605A9D679@hotmail.com>
2008-12-25  4:37       ` C.W. Betts
2008-12-25  7:06     ` Avi Kivity
2008-12-25  7:07     ` Avi Kivity
2008-12-25  7:08     ` Avi Kivity
2008-12-25 14:51       ` Liraz Siri
2008-12-25 16:14         ` Avi Kivity
2008-12-24 23:18   ` Jamie Lokier
2008-12-25  7:11     ` Avi Kivity
2008-12-24 15:23 ` Anthony Liguori
2008-12-24 20:21   ` Liraz Siri
2008-12-24 20:55   ` Liraz Siri
2009-01-05 21:12   ` Frank Mehnert
2009-01-05 22:03     ` Stefan Weil
2009-01-05 23:58     ` Anthony Liguori
2009-01-06  7:41       ` Frank Mehnert
2009-01-06 15:46         ` Blue Swirl
2009-01-06 17:33         ` Anthony Liguori
2009-01-06 20:40           ` Frank Mehnert
2009-01-06 22:17             ` Jamie Lokier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49525808.9080002@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    --cc=turnkey-discuss@lists.turnkeylinux.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).