From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 330D8C31E5B for ; Mon, 17 Jun 2019 20:53:27 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id ED1602080A for ; Mon, 17 Jun 2019 20:53:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="DE9oQz8N" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org ED1602080A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:51906 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcyd3-0006T5-KE for qemu-devel@archiver.kernel.org; Mon, 17 Jun 2019 16:53:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:41771) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hcybi-00061b-NK for qemu-devel@nongnu.org; Mon, 17 Jun 2019 16:52:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hcybh-0004xn-Rx for qemu-devel@nongnu.org; Mon, 17 Jun 2019 16:52:02 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:45439) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hcybh-0004xJ-LQ for qemu-devel@nongnu.org; Mon, 17 Jun 2019 16:52:01 -0400 Received: by mail-pf1-x442.google.com with SMTP id r1so6295710pfq.12 for ; Mon, 17 Jun 2019 13:52:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:openpgp:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=XUEbgF2AKRB9F0QGH8AzF6bi3J0OLpzXnxg0wzura/A=; b=DE9oQz8N9irNrSI+kAmh4O3hFPXDiNL+nAQ5vY0UOg7tzKA0tOZjLgW2V2JIzWNhcC rkF0G9mGn7laRNqmB0GCgPXV07eynT7xzKneHsZIBIklDfHccwJKFwojwkrGmU2N9MsS CVNbC9RXFoMDNWJrkAqyC7s9yb3tx6ZBwsIBdB22T/HkAh/YZgJZIRTn/o09TWoYuHLn V64WwBwJIyU5bnWQdCIfaZCRl3PqIvMDLm5ZwvgBFkOP3KxxBBnzR+249s5UviBYSx/w bhrs09K1kRwgdMvuTKjM0n0g2SE/uhban9tuuEP5nBO151NqixBO5kqB1uEdKFQQWFqN aUaw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=XUEbgF2AKRB9F0QGH8AzF6bi3J0OLpzXnxg0wzura/A=; b=JQFPymJQH5IWChtkiLz0zmBtyS9HTKZDoWEQvg7Ht7LT52c/iS/d6T5TiIzFGJh4eZ z3dxCUqdbZZlcpoBdU2M7ygDeA4PPmk+ML/OgqPdyMVlwRjwshSignrBG20hHRe9kXdK RvY0zHZjAWI1mfmgtWa4KlUg0PiJIrG3FbVvXHP1DhyOeYEhPkk7rSW2GbwgvdVQBx4h IMi2VnADCtpNoKrjVZzAQj69ofb/QfT94q7QRGw6xYnzZTc4tax5Fvu2b3ScAgAVL3Z2 v0T4cXG7vYC0VhIN7JF9Gipjg632RRvztFucfnwiPAIPKPihivOG7S6bRH/+wg8C+qA+ LAcA== X-Gm-Message-State: APjAAAXd2odhKf/evwOBxUdKlpyKiFlocymyqMXZlDXF5YbZPpj52urG EINs306bVOCv2GUsIuanbkmgfifd1dk= X-Google-Smtp-Source: APXvYqw4oeZd5sSC9K+P5Z79TdJIfWjLH/fp2mU8XwDIu65+TAkmtCwYY0mJLpHJ1SXqzA88X0GUjQ== X-Received: by 2002:a17:90a:9b88:: with SMTP id g8mr997856pjp.100.1560804720418; Mon, 17 Jun 2019 13:52:00 -0700 (PDT) Received: from [192.168.1.11] (97-113-2-33.tukw.qwest.net. [97.113.2.33]) by smtp.gmail.com with ESMTPSA id z4sm12725022pfa.142.2019.06.17.13.51.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 17 Jun 2019 13:51:59 -0700 (PDT) To: =?UTF-8?Q?Alex_Benn=c3=a9e?= , qemu-devel@nongnu.org References: <20190614171200.21078-1-alex.bennee@linaro.org> <20190614171200.21078-20-alex.bennee@linaro.org> From: Richard Henderson Openpgp: preference=signencrypt Message-ID: <49562bfe-16ac-6f5a-ee70-20886a5dc4c5@linaro.org> Date: Mon, 17 Jun 2019 13:51:57 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190614171200.21078-20-alex.bennee@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 Subject: Re: [Qemu-devel] [PATCH v3 19/50] tcg: let plugins instrument memory accesses X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , "Emilio G. Cota" , Richard Henderson Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 6/14/19 10:11 AM, Alex Bennée wrote: > +static inline void set_hostaddr(CPUArchState *env, TCGMemOp mo, void *haddr) > +{ > +#ifdef CONFIG_PLUGIN > + if (mo & MO_HADDR) { > + env_tlb(env)->c.hostaddr = haddr; > + } > +#endif > +} > + Even if we weren't talking about recomputing this in the helper, would an unconditional store be cheaper? r~