From: Steven Sistare <steven.sistare@oracle.com>
To: Markus Armbruster <armbru@redhat.com>, qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, berrange@redhat.com, eduardo@habkost.net
Subject: Re: [PATCH 3/5] qtest/qom-test: Traverse entire QOM tree
Date: Mon, 4 Aug 2025 12:40:20 -0400 [thread overview]
Message-ID: <495859c5-aa6b-4379-8667-a0968f532326@oracle.com> (raw)
In-Reply-To: <20250725135034.2280477-4-armbru@redhat.com>
On 7/25/2025 9:50 AM, Markus Armbruster wrote:
> This test traverses the QOM sub-tree rooted at /machine. Traverse the
> entire tree instead.
>
> The x86_64 test runs some 40 additional QMP commands, and stays under
> 5s for me.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> tests/qtest/qom-test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/qtest/qom-test.c b/tests/qtest/qom-test.c
> index 40bdc3639f..d358b69c7e 100644
> --- a/tests/qtest/qom-test.c
> +++ b/tests/qtest/qom-test.c
> @@ -211,7 +211,7 @@ static void test_machine(gconstpointer data)
>
> test_properties(qts, "/machine", true);
>
> - qlist_append_str(paths, "/machine");
> + qlist_append_str(paths, "/");
> test_list_get(qts, paths);
> test_list_get_value(qts);
Reviewed-by: Steve Sistare <steven.sistare@oracle.com>
next prev parent reply other threads:[~2025-08-04 18:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-25 13:50 [PATCH 0/5] qtest/qom-test: Leak plug, faster, better coverage Markus Armbruster
2025-07-25 13:50 ` [PATCH 1/5] qtest/qom-test: Plug memory leak with -p Markus Armbruster
2025-08-04 17:11 ` Steven Sistare
2025-08-05 6:54 ` Markus Armbruster
2025-08-05 12:07 ` Steven Sistare
2025-07-25 13:50 ` [PATCH 2/5] qtest/qom-test: Shallow testing of qom-list / qom-get Markus Armbruster
2025-08-04 16:38 ` Steven Sistare
2025-07-25 13:50 ` [PATCH 3/5] qtest/qom-test: Traverse entire QOM tree Markus Armbruster
2025-08-04 16:40 ` Steven Sistare [this message]
2025-07-25 13:50 ` [PATCH 4/5] qtest/qom-test: Don't bother to execute QMP command quit Markus Armbruster
2025-08-04 17:10 ` Steven Sistare
2025-08-05 6:06 ` Markus Armbruster
2025-08-05 12:03 ` Steven Sistare
2025-07-25 13:50 ` [PATCH 5/5] MAINTAINERS: Cover tests/qtest/qom-test.c Markus Armbruster
2025-08-04 7:01 ` [PATCH 0/5] qtest/qom-test: Leak plug, faster, better coverage Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=495859c5-aa6b-4379-8667-a0968f532326@oracle.com \
--to=steven.sistare@oracle.com \
--cc=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eduardo@habkost.net \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).