From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LHc5p-0006Qb-Vc for qemu-devel@nongnu.org; Tue, 30 Dec 2008 05:44:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LHc5n-0006QP-Gq for qemu-devel@nongnu.org; Tue, 30 Dec 2008 05:44:56 -0500 Received: from [199.232.76.173] (port=40969 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LHc5n-0006QM-Ap for qemu-devel@nongnu.org; Tue, 30 Dec 2008 05:44:55 -0500 Received: from mx2.redhat.com ([66.187.237.31]:51983) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LHc5m-0001hF-SM for qemu-devel@nongnu.org; Tue, 30 Dec 2008 05:44:55 -0500 Message-ID: <4959FB9D.8030706@redhat.com> Date: Tue, 30 Dec 2008 12:44:45 +0200 From: Avi Kivity MIME-Version: 1.0 References: <1230575362-14485-1-git-send-email-glommer@redhat.com> <18777.63215.125693.799799@mariner.uk.xensource.com> In-Reply-To: <18777.63215.125693.799799@mariner.uk.xensource.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] hook cpu running at a higher level. Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ian Jackson Cc: Glauber Costa , qemu-devel@nongnu.org, kvm@vger.kernel.org, stefano.stabellini@eu.citrix.com Ian Jackson wrote: > The way we have approached these problems in the Xen tree is to supply > an alternative implementation of (say) main_loop and arrange for the > standard one not to be compiled. Is it the intent to make kvm a > run-time selectable option ? It seems to me that that given that we > already have different qemu builds for all of the various target > (guest) cpu architectures, it might be simpler to continue that > approach. With a bit of judicious movement of code into appropriate > files, this will avoid the need for ifs and ifdefs. > kvm is run-time selectable, both in upstream and in kvm-userspace. If kvm is not detected (or the caller lacks sufficient privileges), we fall back to tcg (of course we'd also like the option of not compiling tcg where emulation is unacceptable like server deployments). -- error compiling committee.c: too many arguments to function