From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LJdiC-00052g-HN for qemu-devel@nongnu.org; Sun, 04 Jan 2009 19:52:56 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LJdi9-00052I-3m for qemu-devel@nongnu.org; Sun, 04 Jan 2009 19:52:56 -0500 Received: from [199.232.76.173] (port=49408 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LJdi9-00052F-0Z for qemu-devel@nongnu.org; Sun, 04 Jan 2009 19:52:53 -0500 Received: from mx2.redhat.com ([66.187.237.31]:34687) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LJdi8-0004UU-Jm for qemu-devel@nongnu.org; Sun, 04 Jan 2009 19:52:52 -0500 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n050qqZU029942 for ; Sun, 4 Jan 2009 19:52:52 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n050qnbO006172 for ; Sun, 4 Jan 2009 19:52:51 -0500 Received: from [10.35.1.187] (dhcp-1-187.tlv.redhat.com [10.35.1.187]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n050qmbH018453 for ; Sun, 4 Jan 2009 19:52:48 -0500 Message-ID: <496159DF.5020801@redhat.com> Date: Mon, 05 Jan 2009 02:52:47 +0200 From: Uri Lublin MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] [PATCH] qcow2: free old snapshots array upon creation of a new one Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Don't leak memory Signed-off-by: Uri Lublin --- qemu/block-qcow2.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/qemu/block-qcow2.c b/qemu/block-qcow2.c index b3b5f8f..4a2d0a3 100644 --- a/qemu/block-qcow2.c +++ b/qemu/block-qcow2.c @@ -2021,6 +2021,7 @@ static int qcow_snapshot_create(BlockDriverState *bs, if (!snapshots1) goto fail; memcpy(snapshots1, s->snapshots, s->nb_snapshots * sizeof(QCowSnapshot)); + qemu_free(s->snapshots); s->snapshots = snapshots1; s->snapshots[s->nb_snapshots++] = *sn;