From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LJrNv-0000j3-TJ
	for qemu-devel@nongnu.org; Mon, 05 Jan 2009 10:28:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LJrNv-0000ie-7i
	for qemu-devel@nongnu.org; Mon, 05 Jan 2009 10:28:55 -0500
Received: from [199.232.76.173] (port=47102 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LJrNv-0000iX-31
	for qemu-devel@nongnu.org; Mon, 05 Jan 2009 10:28:55 -0500
Received: from mx2.redhat.com ([66.187.237.31]:46233)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <avi@redhat.com>) id 1LJrNu-0006Dk-Io
	for qemu-devel@nongnu.org; Mon, 05 Jan 2009 10:28:54 -0500
Message-ID: <49622732.4090908@redhat.com>
Date: Mon, 05 Jan 2009 17:28:50 +0200
From: Avi Kivity <avi@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6136] Register reset handlers
References: <E1LH0M2-0000IN-JG@cvs.savannah.gnu.org>
In-Reply-To: <E1LH0M2-0000IN-JG@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org, Blue Swirl <blauwirbel@gmail.com>
Cc: Uri Lublin <ulublin@redhat.com>

Blue Swirl wrote:
> Revision: 6136
>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6136
> Author:   blueswir1
> Date:     2008-12-28 18:27:10 +0000 (Sun, 28 Dec 2008)
>
> Log Message:
> -----------
> Register reset handlers
>
>
> Modified: trunk/hw/vga.c
> ===================================================================
> --- trunk/hw/vga.c	2008-12-28 15:45:20 UTC (rev 6135)
> +++ trunk/hw/vga.c	2008-12-28 18:27:10 UTC (rev 6136)
> @@ -1826,10 +1826,73 @@
>      s->last_height = -1;
>  }
>  
> -static void vga_reset(VGAState *s)
> +static void vga_reset(void *opaque)
>  {
> -    memset(s, 0, sizeof(VGAState));
> +    memset(s->sr, '\0', sizeof(s->sr));
> +    s->gr_index = 0;
> +    memset(s->gr, '\0', sizeof(s->gr));
> +    s->ar_index = 0;
> +    memset(s->ar, '\0', sizeof(s->ar));
> +    s->ar_flip_flop = 0;
> +    s->cr_index = 0;
> +    memset(s->cr, '\0', sizeof(s->cr));
>   

...

>      }
> +    qemu_register_reset(vga_reset, s);
> +    vga_reset(s);
>  }
>  
>   

This breaks cirrus - the reset handler tramples over some cirrus 
registers, and after reset graphic comes up in 640x480 resolution.  I'll 
follow up with a patch.

-- 
error compiling committee.c: too many arguments to function