From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LKac0-0007Am-Ge
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 10:46:28 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LKaby-0007AM-KV
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 10:46:27 -0500
Received: from [199.232.76.173] (port=60915 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LKaby-0007AJ-GH
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 10:46:26 -0500
Received: from ns.suse.de ([195.135.220.2]:59088 helo=mx1.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1LKaby-00010f-3v
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 10:46:26 -0500
Message-ID: <4964CE46.9020207@suse.de>
Date: Wed, 07 Jan 2009 16:46:14 +0100
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] fix usb-hid SET_IDLE behaviour
References: <4964A405.50801@eu.citrix.com>
	<18788.51252.485898.915634@mariner.uk.xensource.com>
In-Reply-To: <18788.51252.485898.915634@mariner.uk.xensource.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Ian.Jackson@eu.citrix.com

Ian Jackson wrote:
> Stefano Stabellini writes ("[Qemu-devel] [PATCH] fix usb-hid SET_IDLE behaviour"):
>   
>> the usb-hid spec states that the SET_IDLE request has a 16bit value,
>> where the upper byte specifies the idle rate (currently unimplemented,
>> we handle only the 0 case, meaning infinite duration) and the lower
>> byte specifies the report id (0 means all reports).
>> In our code we do idle = value, while it should be idle = "upper byte",
>> especially if the guest issues a GET_IDLE, we should return only the
>> idle rate while we are returning only the report id.
>> In practice it doesn't make much difference because I have only seen
>> SET_VALUE with both bytes set to 0 so far, but still it is wrong.
>>
>> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>>     
>
> Stefano's patch looks good to me.
>
> Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>   

Shouldn't that be Ian rather than Stefano? :-)

Alex