From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>
Subject: Re: [Qemu-devel] [PATCH] fix usb-hid SET_IDLE behaviour
Date: Wed, 07 Jan 2009 10:43:46 -0600 [thread overview]
Message-ID: <4964DBC2.3060503@codemonkey.ws> (raw)
In-Reply-To: <4964A405.50801@eu.citrix.com>
Stefano Stabellini wrote:
> Hi all,
> the usb-hid spec states that the SET_IDLE request has a 16bit value,
> where the upper byte specifies the idle rate (currently unimplemented,
> we handle only the 0 case, meaning infinite duration) and the lower
> byte specifies the report id (0 means all reports).
> In our code we do idle = value, while it should be idle = "upper byte",
> especially if the guest issues a GET_IDLE, we should return only the
> idle rate while we are returning only the report id.
> In practice it doesn't make much difference because I have only seen
> SET_VALUE with both bytes set to 0 so far, but still it is wrong.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
prev parent reply other threads:[~2009-01-07 16:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 12:45 [Qemu-devel] [PATCH] fix usb-hid SET_IDLE behaviour Stefano Stabellini
2009-01-07 15:20 ` Ian Jackson
2009-01-07 15:46 ` Alexander Graf
2009-01-07 15:53 ` Ian Jackson
2009-01-07 16:43 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4964DBC2.3060503@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=Ian.Jackson@eu.citrix.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).