From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LKbVa-0006TA-UV
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 11:43:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LKbVZ-0006SO-EA
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 11:43:54 -0500
Received: from [199.232.76.173] (port=57723 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LKbVZ-0006SJ-6Z
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 11:43:53 -0500
Received: from qw-out-1920.google.com ([74.125.92.149]:17281)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LKbVY-0006S1-TK
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 11:43:53 -0500
Received: by qw-out-1920.google.com with SMTP id 5so3854812qwc.4
	for <qemu-devel@nongnu.org>; Wed, 07 Jan 2009 08:43:52 -0800 (PST)
Message-ID: <4964DBC2.3060503@codemonkey.ws>
Date: Wed, 07 Jan 2009 10:43:46 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] fix usb-hid SET_IDLE behaviour
References: <4964A405.50801@eu.citrix.com>
In-Reply-To: <4964A405.50801@eu.citrix.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>

Stefano Stabellini wrote:
> Hi all,
> the usb-hid spec states that the SET_IDLE request has a 16bit value,
> where the upper byte specifies the idle rate (currently unimplemented,
> we handle only the 0 case, meaning infinite duration) and the lower
> byte specifies the report id (0 means all reports).
> In our code we do idle = value, while it should be idle = "upper byte",
> especially if the guest issues a GET_IDLE, we should return only the
> idle rate while we are returning only the report id.
> In practice it doesn't make much difference because I have only seen
> SET_VALUE with both bytes set to 0 so far, but still it is wrong.
>
> Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
>   

Applied. Thanks.

Regards,

Anthony Liguori