From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] qcow2: free old snapshots array upon creation of a new one
Date: Wed, 07 Jan 2009 10:54:12 -0600 [thread overview]
Message-ID: <4964DE34.3050502@codemonkey.ws> (raw)
In-Reply-To: <496159DF.5020801@redhat.com>
Uri Lublin wrote:
> Don't leak memory
>
> Signed-off-by: Uri Lublin <uril@redhat.com>
> ---
> qemu/block-qcow2.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
Please don't send patches against kvm-userspace.
Regards,
Anthony Liguori
> diff --git a/qemu/block-qcow2.c b/qemu/block-qcow2.c
> index b3b5f8f..4a2d0a3 100644
> --- a/qemu/block-qcow2.c
> +++ b/qemu/block-qcow2.c
> @@ -2021,6 +2021,7 @@ static int qcow_snapshot_create(BlockDriverState
> *bs,
> if (!snapshots1)
> goto fail;
> memcpy(snapshots1, s->snapshots, s->nb_snapshots *
> sizeof(QCowSnapshot));
> + qemu_free(s->snapshots);
> s->snapshots = snapshots1;
> s->snapshots[s->nb_snapshots++] = *sn;
>
>
>
>
next prev parent reply other threads:[~2009-01-07 16:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-05 0:52 [Qemu-devel] [PATCH] qcow2: free old snapshots array upon creation of a new one Uri Lublin
2009-01-07 16:54 ` Anthony Liguori [this message]
2009-01-07 17:27 ` Johannes Schindelin
2009-01-08 13:52 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4964DE34.3050502@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).