From: Kevin Wolf <kwolf@suse.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qcow1 compression
Date: Wed, 07 Jan 2009 18:56:58 +0100 [thread overview]
Message-ID: <4964ECEA.8090600@suse.de> (raw)
In-Reply-To: <200901071824.40113.uli@suse.de>
Ulrich Hecht schrieb:
> I have received a bug report from one of our users about compression in
> qcow(1). He converted disk images to qcow with compression, and the
> resulting images did not work. I looked into block-qcow.c and found
> several huge and, as it seems, long-standing bugs. For instance,
> QCOW_OFLAG_COMPRESSED is never set anywhere, causing compressed data to
> be returned verbatim on reading.
>
> I'd like to get people's opinion on whether there is any point in fixing
> this stuff, considering that there is qcow2, and that it never worked to
> begin with. Perhaps a patch removing it would make more sense...
It definitely worked at some point and a quick look seems to show that
the last patch to block-qcow.c (Rev 4673) breaks it. Despite the commit
comment, the code wasn't all that dead: allocate == 2 is different from
allocate == 1.
Reverting that patch should be enough (and possibly adding a comment so
that it won't be broken again in future).
Kevin
next prev parent reply other threads:[~2009-01-07 17:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 17:24 [Qemu-devel] qcow1 compression Ulrich Hecht
2009-01-07 17:56 ` Kevin Wolf [this message]
2009-01-08 12:15 ` Ulrich Hecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4964ECEA.8090600@suse.de \
--to=kwolf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).