From: Anthony Liguori <anthony@codemonkey.ws>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [6219] add missing MAC address to info_str for some NICs (Mark McLoughlin)
Date: Wed, 07 Jan 2009 14:00:08 -0600 [thread overview]
Message-ID: <496509C8.6090008@codemonkey.ws> (raw)
In-Reply-To: <4964FBE3.5070603@mail.berlios.de>
Stefan Weil wrote:
> Anthony Liguori schrieb:
>
>> Revision: 6219
>> http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6219
>> Author: aliguori
>> Date: 2009-01-07 17:47:15 +0000 (Wed, 07 Jan 2009)
>>
>> Log Message:
>> -----------
>> add missing MAC address to info_str for some NICs (Mark McLoughlin)
>>
>> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>> Modified Paths:
>> --------------
>> trunk/hw/mcf_fec.c
>> trunk/hw/smc91c111.c
>> trunk/hw/stellaris_enet.c
>> trunk/hw/virtio-net.c
>>
>> Modified: trunk/hw/mcf_fec.c
>> ===================================================================
>> --- trunk/hw/mcf_fec.c 2009-01-07 17:46:21 UTC (rev 6218)
>> +++ trunk/hw/mcf_fec.c 2009-01-07 17:47:15 UTC (rev 6219)
>> @@ -455,4 +455,5 @@
>> s->vc = qemu_new_vlan_client(nd->vlan, nd->model,
>> mcf_fec_receive, mcf_fec_can_receive, s);
>> memcpy(s->macaddr, nd->macaddr, 6);
>> + qemu_format_nic_info_str(n->vc, s->macaddr);
>> }
>>
>>
>>
>
> s->vc looks better than n->vc :-)
>
Good catch.
Regards,
Anthony Liguori
> Regards
> Stefan Weil
>
>
>
>
next prev parent reply other threads:[~2009-01-07 20:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-07 17:47 [Qemu-devel] [6219] add missing MAC address to info_str for some NICs (Mark McLoughlin) Anthony Liguori
2009-01-07 19:00 ` Stefan Weil
2009-01-07 20:00 ` Anthony Liguori [this message]
2009-01-08 9:45 ` Mark McLoughlin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496509C8.6090008@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).