From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LKeZf-0005O5-73
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 15:00:19 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LKeZd-0005N5-I9
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 15:00:18 -0500
Received: from [199.232.76.173] (port=34930 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LKeZd-0005My-AZ
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 15:00:17 -0500
Received: from ey-out-1920.google.com ([74.125.78.144]:55036)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LKeZc-0003kX-Va
	for qemu-devel@nongnu.org; Wed, 07 Jan 2009 15:00:17 -0500
Received: by ey-out-1920.google.com with SMTP id 26so773389eyw.4
	for <qemu-devel@nongnu.org>; Wed, 07 Jan 2009 12:00:15 -0800 (PST)
Message-ID: <496509C8.6090008@codemonkey.ws>
Date: Wed, 07 Jan 2009 14:00:08 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6219] add missing MAC address to info_str for some
	NICs (Mark McLoughlin)
References: <E1LKcUt-0007gH-NG@cvs.savannah.gnu.org>
	<4964FBE3.5070603@mail.berlios.de>
In-Reply-To: <4964FBE3.5070603@mail.berlios.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Stefan Weil wrote:
> Anthony Liguori schrieb:
>   
>> Revision: 6219
>>           http://svn.sv.gnu.org/viewvc/?view=rev&root=qemu&revision=6219
>> Author:   aliguori
>> Date:     2009-01-07 17:47:15 +0000 (Wed, 07 Jan 2009)
>>
>> Log Message:
>> -----------
>> add missing MAC address to info_str for some NICs (Mark McLoughlin)
>>
>> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>>
>> Modified Paths:
>> --------------
>>     trunk/hw/mcf_fec.c
>>     trunk/hw/smc91c111.c
>>     trunk/hw/stellaris_enet.c
>>     trunk/hw/virtio-net.c
>>
>> Modified: trunk/hw/mcf_fec.c
>> ===================================================================
>> --- trunk/hw/mcf_fec.c	2009-01-07 17:46:21 UTC (rev 6218)
>> +++ trunk/hw/mcf_fec.c	2009-01-07 17:47:15 UTC (rev 6219)
>> @@ -455,4 +455,5 @@
>>      s->vc = qemu_new_vlan_client(nd->vlan, nd->model,
>>                                   mcf_fec_receive, mcf_fec_can_receive, s);
>>      memcpy(s->macaddr, nd->macaddr, 6);
>> +    qemu_format_nic_info_str(n->vc, s->macaddr);
>>  }
>>
>>   
>>     
>
> s->vc looks better than n->vc :-)
>   

Good catch.

Regards,

Anthony Liguori

> Regards
> Stefan Weil
>
>
>
>