From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LKvJB-0006VN-O5 for qemu-devel@nongnu.org; Thu, 08 Jan 2009 08:52:26 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LKvJ9-0006Uh-HG for qemu-devel@nongnu.org; Thu, 08 Jan 2009 08:52:24 -0500 Received: from [199.232.76.173] (port=36591 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LKvJ8-0006UU-Ex for qemu-devel@nongnu.org; Thu, 08 Jan 2009 08:52:22 -0500 Received: from mx2.redhat.com ([66.187.237.31]:35848) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LKvJ7-0002GT-UP for qemu-devel@nongnu.org; Thu, 08 Jan 2009 08:52:22 -0500 Message-ID: <4966050E.3010105@redhat.com> Date: Thu, 08 Jan 2009 15:52:14 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] qcow2: free old snapshots array upon creation of a new one References: <496159DF.5020801@redhat.com> <4964DE34.3050502@codemonkey.ws> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Johannes Schindelin wrote: > Hi, > > On Wed, 7 Jan 2009, Anthony Liguori wrote: > > >> Uri Lublin wrote: >> >>> Don't leak memory >>> >>> Signed-off-by: Uri Lublin >>> --- >>> qemu/block-qcow2.c | 1 + >>> 1 files changed, 1 insertions(+), 0 deletions(-) >>> >> Please don't send patches against kvm-userspace. >> > > git am -p2 > That doesn't test the patch against upstream qemu. -- error compiling committee.c: too many arguments to function