From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LL0RN-0007jD-Gg
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:21:13 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LL0RK-0007im-Q6
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:21:12 -0500
Received: from [199.232.76.173] (port=58795 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LL0RK-0007ig-GX
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:21:10 -0500
Received: from qw-out-1920.google.com ([74.125.92.146]:36918)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LL0RK-00031d-5G
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:21:10 -0500
Received: by qw-out-1920.google.com with SMTP id 5so4164918qwc.4
	for <qemu-devel@nongnu.org>; Thu, 08 Jan 2009 11:21:08 -0800 (PST)
Message-ID: <4966521D.1020706@codemonkey.ws>
Date: Thu, 08 Jan 2009 13:21:01 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3 2/5] Add vmchannel command line option.
References: <20090108095533.12548.8211.stgit@dhcp-1-237.tlv.redhat.com>
	<20090108095544.12548.21251.stgit@dhcp-1-237.tlv.redhat.com>
In-Reply-To: <20090108095544.12548.21251.stgit@dhcp-1-237.tlv.redhat.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Gleb Natapov wrote:
> Signed-off-by: Gleb Natapov <gleb@redhat.com>
> ---
>
>  vl.c |   75 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-
>  1 files changed, 74 insertions(+), 1 deletions(-)
>
> diff --git a/vl.c b/vl.c
> index 959be62..c076375 100644
> --- a/vl.c
> +++ b/vl.c
> @@ -207,6 +207,13 @@ static int full_screen = 0;
>  static int no_frame = 0;
>  #endif
>  int no_quit = 0;
> +#if defined(CONFIG_SLIRP)
> +#define MAX_VMCHANNEL_DEVICES 4
> +struct VMChannel {
> +    CharDriverState *hd;
> +    int port;
> +} vmchannel_hds[MAX_VMCHANNEL_DEVICES];
> +#endif
>  CharDriverState *serial_hds[MAX_SERIAL_PORTS];
>  CharDriverState *parallel_hds[MAX_PARALLEL_PORTS];
>  #ifdef TARGET_I386
> @@ -3948,6 +3955,9 @@ static void help(int exitcode)
>             "-monitor dev    redirect the monitor to char device 'dev'\n"
>             "-serial dev     redirect the serial port to char device 'dev'\n"
>             "-parallel dev   redirect the parallel port to char device 'dev'\n"
> +#if defined(CONFIG_SLIRP)
> +	   "-vmchannel di:DI,dev  redirect the vmchannel device with device id DI, to char device 'dev'\n"
> +#endif
>             "-pidfile file   Write PID to 'file'\n"
>             "-S              freeze CPU at startup (use 'c' to start execution)\n"
>             "-s              wait gdb connection to port\n"
> @@ -4062,6 +4072,9 @@ enum {
>      QEMU_OPTION_monitor,
>      QEMU_OPTION_serial,
>      QEMU_OPTION_parallel,
> +#if defined(CONFIG_SLIRP)
> +    QEMU_OPTION_vmchannel,
> +#endif
>   

I think this would make more sense as an option to -net user.  For instance:

-net user,port=1024,chardev=unix:foo.sock

Not the best syntax, but you get the idea.  What do you think?

It may be useful to use this functionality for other things too.

Regards,

Anthony Liguroi