From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LL0z1-0007dw-Lk for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:55:59 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LL0yz-0007cr-TN for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:55:59 -0500 Received: from [199.232.76.173] (port=36635 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LL0yz-0007cl-Ni for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:55:57 -0500 Received: from mail-ew0-f21.google.com ([209.85.219.21]:42981) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LL0yz-0000b2-4v for qemu-devel@nongnu.org; Thu, 08 Jan 2009 14:55:57 -0500 Received: by ewy14 with SMTP id 14so10395449ewy.10 for ; Thu, 08 Jan 2009 11:55:55 -0800 (PST) Message-ID: <49665A42.3050001@codemonkey.ws> Date: Thu, 08 Jan 2009 13:55:46 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH v3 2/5] Add vmchannel command line option. References: <20090108095533.12548.8211.stgit@dhcp-1-237.tlv.redhat.com> <20090108095544.12548.21251.stgit@dhcp-1-237.tlv.redhat.com> <4966521D.1020706@codemonkey.ws> <20090108193545.GC8669@redhat.com> In-Reply-To: <20090108193545.GC8669@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Daniel P. Berrange wrote: > On Thu, Jan 08, 2009 at 01:21:01PM -0600, Anthony Liguori wrote: > >> Gleb Natapov wrote: >> >>> Signed-off-by: Gleb Natapov >>> --- >>> >>> vl.c | 75 >>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++- >>> 1 files changed, 74 insertions(+), 1 deletions(-) >>> >>> diff --git a/vl.c b/vl.c >>> index 959be62..c076375 100644 >>> --- a/vl.c >>> +++ b/vl.c >>> @@ -207,6 +207,13 @@ static int full_screen = 0; >>> static int no_frame = 0; >>> #endif >>> int no_quit = 0; >>> +#if defined(CONFIG_SLIRP) >>> +#define MAX_VMCHANNEL_DEVICES 4 >>> +struct VMChannel { >>> + CharDriverState *hd; >>> + int port; >>> +} vmchannel_hds[MAX_VMCHANNEL_DEVICES]; >>> +#endif >>> CharDriverState *serial_hds[MAX_SERIAL_PORTS]; >>> CharDriverState *parallel_hds[MAX_PARALLEL_PORTS]; >>> #ifdef TARGET_I386 >>> @@ -3948,6 +3955,9 @@ static void help(int exitcode) >>> "-monitor dev redirect the monitor to char device 'dev'\n" >>> "-serial dev redirect the serial port to char device >>> 'dev'\n" >>> "-parallel dev redirect the parallel port to char device >>> 'dev'\n" >>> +#if defined(CONFIG_SLIRP) >>> + "-vmchannel di:DI,dev redirect the vmchannel device with device >>> id DI, to char device 'dev'\n" >>> +#endif >>> "-pidfile file Write PID to 'file'\n" >>> "-S freeze CPU at startup (use 'c' to start >>> execution)\n" >>> "-s wait gdb connection to port\n" >>> @@ -4062,6 +4072,9 @@ enum { >>> QEMU_OPTION_monitor, >>> QEMU_OPTION_serial, >>> QEMU_OPTION_parallel, >>> +#if defined(CONFIG_SLIRP) >>> + QEMU_OPTION_vmchannel, >>> +#endif >>> >>> >> I think this would make more sense as an option to -net user. For instance: >> >> -net user,port=1024,chardev=unix:foo.sock >> >> Not the best syntax, but you get the idea. What do you think? >> >> It may be useful to use this functionality for other things too. >> > > If I'm understanding correctly, the VM channel stuff has a hard > requirement for Slirp/user net setup, so could you just go one > step further and use the full char device syntax with -net, thus > eliminating the redundant 'user:' bit ? > > -net char:[CHAR-DEV-OPTIONS],port=1024 > > Or > > -net vmchan:[CHAR-DEV-OPTIONS],port=1024 > > Where 'CHAR-DEV-OPTIONS' is any of the stuff valid for -serial/-parallal > char device options > Yeah, that would be nice too. My main point was moving it from a standalone option to something that was part of net. I'd avoid the name "vmchan" though. Regards, Anthony Liguori > Daniel >