From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LL1ac-0007vP-Ae for qemu-devel@nongnu.org; Thu, 08 Jan 2009 15:34:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LL1aZ-0007up-UI for qemu-devel@nongnu.org; Thu, 08 Jan 2009 15:34:50 -0500 Received: from [199.232.76.173] (port=41220 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LL1aZ-0007um-Lv for qemu-devel@nongnu.org; Thu, 08 Jan 2009 15:34:47 -0500 Received: from e6.ny.us.ibm.com ([32.97.182.146]:56292) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LL1aZ-0004wg-DG for qemu-devel@nongnu.org; Thu, 08 Jan 2009 15:34:47 -0500 Received: from d01relay04.pok.ibm.com (d01relay04.pok.ibm.com [9.56.227.236]) by e6.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n08KYnDl009740 for ; Thu, 8 Jan 2009 15:34:49 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay04.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n08KYhq5155912 for ; Thu, 8 Jan 2009 15:34:43 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n08KXucv001403 for ; Thu, 8 Jan 2009 15:33:57 -0500 Message-ID: <4966635E.8090205@us.ibm.com> Date: Thu, 08 Jan 2009 14:34:38 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1231422848-32179-1-git-send-email-ehrhardt@linux.vnet.ibm.com> In-Reply-To: <1231422848-32179-1-git-send-email-ehrhardt@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] qemu: report issues causing the kvm probe to fail v3 Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ehrhardt@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, avi@qumranet.com, kvm@vger.kernel.org ehrhardt@linux.vnet.ibm.com wrote: > From: Christian Ehrhardt > > The patch applies to upstream qemu as well as kvm-userspace, but since it is > the qemu configure script I think it should go to upstream qemu (Anthony) > first and with the next merge to kvm-userspace. On the other hand it is the kvm > probe so an ack from Avi in case v3 is ok would be reasonable. > > *updates* > v2 - it also reports other errors than just #error preprocessor statements > (requested by Avi) > v3 - In case awk or grep is not installed it now gracfully (silently) > fails still disabling kvm (requested by Anthony) > > This patch is about reporting more details of the issue if configuring kvm > fails. Therefore this patch keeps the qemu style configure output which is a > list of "$Feature $Status", but extend the "no" result like "KVM Support no" > with some more information. > > There might be a lot of things going wrong with that probe and I don't want > to handle all of them, but if it is one of the known checks e.g. for > KVM_API_VERSION then we could grep/awk that out and report it. The patch > reports in case of a known case in the style > "KVM support no - (Missing KVM capability KVM_CAP_DESTROY_MEMORY_REGION_WORKS)" > > In case more than one #error is triggered it creates a comma separated list in > those brackets and in case it is something else than an #error it just reports > plain old "no". > > Signed-off-by: Christian Ehrhardt > --- > > configure | 27 ++++++++++++++++++++------- > 1 file changed, 20 insertions(+), 7 deletions(-) > > diff --git a/qemu/configure b/qemu/configure > --- a/qemu/configure > +++ b/qemu/configure > Please send against upstream QEMU. Regards, Anthony Liguori