From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LL4EI-0006nJ-8p for qemu-devel@nongnu.org; Thu, 08 Jan 2009 18:23:58 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LL4EG-0006m8-Fj for qemu-devel@nongnu.org; Thu, 08 Jan 2009 18:23:57 -0500 Received: from [199.232.76.173] (port=35020 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LL4EG-0006lw-8S for qemu-devel@nongnu.org; Thu, 08 Jan 2009 18:23:56 -0500 Received: from yx-out-1718.google.com ([74.125.44.157]:25644) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LL4EG-0005gZ-1N for qemu-devel@nongnu.org; Thu, 08 Jan 2009 18:23:56 -0500 Received: by yx-out-1718.google.com with SMTP id 3so3408068yxi.82 for ; Thu, 08 Jan 2009 15:23:55 -0800 (PST) Message-ID: <49668B01.60002@codemonkey.ws> Date: Thu, 08 Jan 2009 17:23:45 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] qemu: block.c: introducing "fmt:FMT:" prefix to image-filenames References: <496642BD.4010706@redhat.com> <20090108185256.GA8669@redhat.com> <49664F54.7050908@redhat.com> <20090108191301.GB8669@redhat.com> <496650ED.1060602@redhat.com> <20090108231854.GB12848@shareable.org> In-Reply-To: <20090108231854.GB12848@shareable.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Jamie Lokier wrote: > Uri Lublin wrote: > >> Daniel P. Berrange wrote: >> >>> Yes the format you write into the qcow2 header can still use the >>> fmt:qcow2: prefix - just no need to expose that particular qcow2 >>> specific implementation detail on the CLI. >>> >> OK. I'll prepare a patch that adds '-F fmt' to 'qemu-img create -b ...' >> > > Will it break backing files whose filename begins with "fmt:"? > > Just because I hate hidden "some filenames work, some filenames break > mysteriously, and of course it's not documented" dodgy hacks. > I'm pretty certain that you couldn't do that today in QEMU. The colon has always been used for protocol checking and if the protocol is invalid, I think we throw an error. Regards, Anthony Liguori > -- Jamie > > >