From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LL5Q1-0003eS-2H
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 19:40:09 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LL5Pz-0003eG-JM
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 19:40:08 -0500
Received: from [199.232.76.173] (port=38590 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LL5Pz-0003eD-H9
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 19:40:07 -0500
Received: from rn-out-0910.google.com ([64.233.170.184]:59558)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LL5Pz-0005qz-7W
	for qemu-devel@nongnu.org; Thu, 08 Jan 2009 19:40:07 -0500
Received: by rn-out-0910.google.com with SMTP id 56so5969280rnw.8
	for <qemu-devel@nongnu.org>; Thu, 08 Jan 2009 16:40:06 -0800 (PST)
Message-ID: <49669D33.3060208@codemonkey.ws>
Date: Thu, 08 Jan 2009 18:41:23 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6247] Add 'set_link' monitor command (Mark
	McLoughlin)
References: <E1LL0nW-0007EB-Jp@cvs.savannah.gnu.org>
	<20090109001951.GA29388@edgar.se.axis.com>
In-Reply-To: <20090109001951.GA29388@edgar.se.axis.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: "Edgar E. Iglesias" <edgar.iglesias@axis.com>
Cc: markmc@redhat.com, qemu-devel@nongnu.org

Edgar E. Iglesias wrote:
> Hello,
>
> I ran into an issue here with the etrax boards. set_link does not
> handle multiple nics on the same vlan
> I'd like to apply the following soon unless someone objects.
>   

Looks good to me.

Regards,

Anthony Liguori

> Best regards
>
> diff --git a/net.c b/net.c
> index fa9fa94..0bb38e4 100644
> --- a/net.c
> +++ b/net.c
> @@ -1703,7 +1703,8 @@ int do_set_link(const char *name, const char *up_or_down)
>      for (vlan = first_vlan; vlan != NULL; vlan = vlan->next)
>          for (vc = vlan->first_client; vc != NULL; vc = vc->next)
>              if (strcmp(vc->name, name) == 0)
> -                break;
> +                goto done;
> +done:
>  
>      if (!vc) {
>          term_printf("could not find network device '%s'", name);
>