From: Kevin Wolf <kwolf@suse.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu: block.c: introducing "fmt:FMT:" prefix to image-filenames
Date: Fri, 09 Jan 2009 10:17:12 +0100 [thread overview]
Message-ID: <49671618.3080102@suse.de> (raw)
In-Reply-To: <20090108231854.GB12848@shareable.org>
Jamie Lokier schrieb:
> Uri Lublin wrote:
>> Daniel P. Berrange wrote:
>>> Yes the format you write into the qcow2 header can still use the
>>> fmt:qcow2: prefix - just no need to expose that particular qcow2
>>> specific implementation detail on the CLI.
>> OK. I'll prepare a patch that adds '-F fmt' to 'qemu-img create -b ...'
>
> Will it break backing files whose filename begins with "fmt:"?
>
> Just because I hate hidden "some filenames work, some filenames break
> mysteriously, and of course it's not documented" dodgy hacks.
Uri, now that you are making the change in qcow2 instead of block.c,
have you thought about using the earlier suggested "filename.img\0qcow2"
hack? This shouldn't break filenames.
Kevin
next prev parent reply other threads:[~2009-01-09 9:11 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-08 18:15 [Qemu-devel] qemu: block.c: introducing "fmt:FMT:" prefix to image-filenames Uri Lublin
2009-01-08 18:52 ` Daniel P. Berrange
2009-01-08 19:04 ` Anthony Liguori
2009-01-08 19:09 ` Uri Lublin
2009-01-08 19:13 ` Daniel P. Berrange
2009-01-08 19:15 ` Uri Lublin
2009-01-08 23:18 ` Jamie Lokier
2009-01-08 23:23 ` Anthony Liguori
2009-01-09 0:15 ` Jamie Lokier
2009-01-09 9:17 ` Kevin Wolf [this message]
2009-01-11 20:42 ` Uri Lublin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=49671618.3080102@suse.de \
--to=kwolf@suse.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).