From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LLDP7-0004z2-SI
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 04:11:45 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LLDP7-0004yC-9e
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 04:11:45 -0500
Received: from [199.232.76.173] (port=34641 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LLDP7-0004xu-5C
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 04:11:45 -0500
Received: from cantor2.suse.de ([195.135.220.15]:36837 helo=mx2.suse.de)
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <kwolf@suse.de>) id 1LLDP6-0003le-Ru
	for qemu-devel@nongnu.org; Fri, 09 Jan 2009 04:11:45 -0500
Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx2.suse.de (Postfix) with ESMTP id 3CF8547E72
	for <qemu-devel@nongnu.org>; Fri,  9 Jan 2009 10:11:43 +0100 (CET)
Message-ID: <49671618.3080102@suse.de>
Date: Fri, 09 Jan 2009 10:17:12 +0100
From: Kevin Wolf <kwolf@suse.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] qemu: block.c: introducing "fmt:FMT:" prefix to
	image-filenames
References: <496642BD.4010706@redhat.com>
	<20090108185256.GA8669@redhat.com>	<49664F54.7050908@redhat.com>
	<20090108191301.GB8669@redhat.com>	<496650ED.1060602@redhat.com>
	<20090108231854.GB12848@shareable.org>
In-Reply-To: <20090108231854.GB12848@shareable.org>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Jamie Lokier schrieb:
> Uri Lublin wrote:
>> Daniel P. Berrange wrote:
>>> Yes the format you write into the qcow2 header can still use the 
>>> fmt:qcow2: prefix - just no need to expose that particular qcow2
>>> specific implementation detail on the CLI. 
>> OK. I'll prepare a patch that adds '-F fmt' to 'qemu-img create -b ...'
> 
> Will it break backing files whose filename begins with "fmt:"?
> 
> Just because I hate hidden "some filenames work, some filenames break
> mysteriously, and of course it's not documented" dodgy hacks.

Uri, now that you are making the change in qcow2 instead of block.c,
have you thought about using the earlier suggested "filename.img\0qcow2"
hack? This shouldn't break filenames.

Kevin