qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony@codemonkey.ws>
To: Paul Brook <paul@codesourcery.com>
Cc: Mark McLoughlin <markmc@redhat.com>,
	qemu-devel@nongnu.org, Alex Williamson <alex.williamson@hp.com>,
	kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 0/5][RFC] virtio-net: MAC filtering
Date: Fri, 09 Jan 2009 14:00:40 -0600	[thread overview]
Message-ID: <4967ACE8.2030001@codemonkey.ws> (raw)
In-Reply-To: <200901091156.08710.paul@codesourcery.com>

Paul Brook wrote:
>>>> A concern here is the growing size of the virtio-net I/O port space
>>>> config.  This series brings it up to 256 bytes with PCI resource
>>>>         
>>> This is one reason why IO ports are a reallybad idea. Use memory mapped
>>> register spaces like any other sane system and you won't have a problem.
>>>       
>> IO ports are much faster for notification than MMIO in KVM which is why
>> the space is currently IO ports.  It was never meant to hold very large
>> amounts of data.
>>     
>
> Huh, I'm surprised it makes any real difference. Other that initial setup, 
> isn't it just used to "kick" the devieonce after new dscriptors have been 
> added to the ring buffer? I'd expect to be a fairly expensive operation 
> (bouncing back to userspace).
>   

It's about 2x as expensive to go to userspace but only probably 1.5x 
expensive to do MMIO compared to PIO.  In the grand scheme of things, 
I'm not sure that it matters that much.  It's relatively simple for 
someone to try out the change and do some benchmarking.

The tougher thing is providing backwards compatible support.

Regards,

Anthony Liguori

> Paul
>   

  reply	other threads:[~2009-01-09 20:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 17:37 [Qemu-devel] [PATCH 0/5][RFC] virtio-net: MAC filtering Alex Williamson
2009-01-09 19:27 ` Paul Brook
2009-01-09 19:37   ` Avi Kivity
2009-01-09 19:41   ` Anthony Liguori
2009-01-09 19:56     ` Paul Brook
2009-01-09 20:00       ` Anthony Liguori [this message]
2009-01-11  8:32     ` Avi Kivity
2009-01-13 21:23 ` [Qemu-devel] [PATCH 0/5] " Alex Williamson
2009-01-13 21:54   ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4967ACE8.2030001@codemonkey.ws \
    --to=anthony@codemonkey.ws \
    --cc=alex.williamson@hp.com \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).