From: Anthony Liguori <aliguori@us.ibm.com>
To: ehrhardt@linux.vnet.ibm.com
Cc: qemu-devel@nongnu.org, avi@qumranet.com, kvm@vger.kernel.org
Subject: [Qemu-devel] Re: [PATCH] qemu: fix configuring kvm probe when using --kerneldir
Date: Fri, 09 Jan 2009 14:05:22 -0600 [thread overview]
Message-ID: <4967AE02.7010104@us.ibm.com> (raw)
In-Reply-To: <1231503054-10618-1-git-send-email-ehrhardt@linux.vnet.ibm.com>
ehrhardt@linux.vnet.ibm.com wrote:
> From: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
>
> There is already a variable kvm_cflags which gets the path of the kernel
> includes when using --kerneldir. But eventually with newer kernels we all will
> need arch/$arch/include too (my case was a incldue of asm/kvm.h which was not
> found anymore). Headers in a full kernel source are not flattened to
> one arch like they are if e.g. installed kernel headers are used.
>
> To fix that, the includes added to cflags depending on --kerneldir should also
> contian the arch includes. The patch adds a special check for x86 because its
> source layout recently changed, all others directly use arch/$cpu/include if
> existent.
>
> Signed-off-by: Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
>
Applied. Thanks.
Regards,
Anthony Liguori
> ---
>
> [diffstat]
> configure | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> [diff]
> diff --git a/configure b/configure
> --- a/configure
> +++ b/configure
> @@ -963,6 +963,12 @@ EOF
> EOF
> if test "$kerneldir" != "" ; then
> kvm_cflags=-I"$kerneldir"/include
> + if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) \
> + -a -d "$kerneldir/arch/x86/include" ; then
> + kvm_cflags="$kvm_cflags -I$kerneldir/arch/x86/include"
> + elif test -d "$kerneldir/arch/$cpu/include" ; then
> + kvm_cflags="$kvm_cflags -I$kerneldir/arch/$cpu/include"
> + fi
> else
> kvm_cflags=""
> fi
>
prev parent reply other threads:[~2009-01-09 20:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-09 12:10 [Qemu-devel] [PATCH] qemu: fix configuring kvm probe when using --kerneldir ehrhardt
2009-01-09 14:36 ` [Qemu-devel] " Andre Przywara
2009-01-12 6:42 ` Christian Ehrhardt
2009-01-09 20:05 ` Anthony Liguori [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4967AE02.7010104@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=avi@qumranet.com \
--cc=ehrhardt@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).