From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LLNbt-0007Ow-0Q for qemu-devel@nongnu.org; Fri, 09 Jan 2009 15:05:37 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LLNbr-0007Mi-2V for qemu-devel@nongnu.org; Fri, 09 Jan 2009 15:05:36 -0500 Received: from [199.232.76.173] (port=48041 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLNbq-0007MQ-Gp for qemu-devel@nongnu.org; Fri, 09 Jan 2009 15:05:34 -0500 Received: from e5.ny.us.ibm.com ([32.97.182.145]:49721) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LLNbp-000338-WE for qemu-devel@nongnu.org; Fri, 09 Jan 2009 15:05:34 -0500 Received: from d01relay02.pok.ibm.com (d01relay02.pok.ibm.com [9.56.227.234]) by e5.ny.us.ibm.com (8.13.1/8.13.1) with ESMTP id n09K3xiP015670 for ; Fri, 9 Jan 2009 15:03:59 -0500 Received: from d01av02.pok.ibm.com (d01av02.pok.ibm.com [9.56.224.216]) by d01relay02.pok.ibm.com (8.13.8/8.13.8/NCO v9.1) with ESMTP id n09K5TDd194318 for ; Fri, 9 Jan 2009 15:05:29 -0500 Received: from d01av02.pok.ibm.com (loopback [127.0.0.1]) by d01av02.pok.ibm.com (8.12.11.20060308/8.13.3) with ESMTP id n09K4gXh008572 for ; Fri, 9 Jan 2009 15:04:42 -0500 Message-ID: <4967AE02.7010104@us.ibm.com> Date: Fri, 09 Jan 2009 14:05:22 -0600 From: Anthony Liguori MIME-Version: 1.0 References: <1231503054-10618-1-git-send-email-ehrhardt@linux.vnet.ibm.com> In-Reply-To: <1231503054-10618-1-git-send-email-ehrhardt@linux.vnet.ibm.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: [Qemu-devel] Re: [PATCH] qemu: fix configuring kvm probe when using --kerneldir Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: ehrhardt@linux.vnet.ibm.com Cc: qemu-devel@nongnu.org, avi@qumranet.com, kvm@vger.kernel.org ehrhardt@linux.vnet.ibm.com wrote: > From: Christian Ehrhardt > > There is already a variable kvm_cflags which gets the path of the kernel > includes when using --kerneldir. But eventually with newer kernels we all will > need arch/$arch/include too (my case was a incldue of asm/kvm.h which was not > found anymore). Headers in a full kernel source are not flattened to > one arch like they are if e.g. installed kernel headers are used. > > To fix that, the includes added to cflags depending on --kerneldir should also > contian the arch includes. The patch adds a special check for x86 because its > source layout recently changed, all others directly use arch/$cpu/include if > existent. > > Signed-off-by: Christian Ehrhardt > Applied. Thanks. Regards, Anthony Liguori > --- > > [diffstat] > configure | 6 ++++++ > 1 file changed, 6 insertions(+) > > [diff] > diff --git a/configure b/configure > --- a/configure > +++ b/configure > @@ -963,6 +963,12 @@ EOF > EOF > if test "$kerneldir" != "" ; then > kvm_cflags=-I"$kerneldir"/include > + if test \( "$cpu" = "i386" -o "$cpu" = "x86_64" \) \ > + -a -d "$kerneldir/arch/x86/include" ; then > + kvm_cflags="$kvm_cflags -I$kerneldir/arch/x86/include" > + elif test -d "$kerneldir/arch/$cpu/include" ; then > + kvm_cflags="$kvm_cflags -I$kerneldir/arch/$cpu/include" > + fi > else > kvm_cflags="" > fi >