From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LLQuc-00088Z-SX for qemu-devel@nongnu.org; Fri, 09 Jan 2009 18:37:10 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LLQuW-000827-CH for qemu-devel@nongnu.org; Fri, 09 Jan 2009 18:37:09 -0500 Received: from [199.232.76.173] (port=38757 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLQuW-000820-94 for qemu-devel@nongnu.org; Fri, 09 Jan 2009 18:37:04 -0500 Received: from yx-out-1718.google.com ([74.125.44.156]:57425) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LLQuV-00082k-Ta for qemu-devel@nongnu.org; Fri, 09 Jan 2009 18:37:04 -0500 Received: by yx-out-1718.google.com with SMTP id 3so3612397yxi.82 for ; Fri, 09 Jan 2009 15:37:02 -0800 (PST) Message-ID: <4967DF96.6090209@codemonkey.ws> Date: Fri, 09 Jan 2009 17:36:54 -0600 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 2/2] Add phenom CPU descriptor References: <1231171871-2320-1-git-send-email-agraf@suse.de> <1231171871-2320-2-git-send-email-agraf@suse.de> <1231171871-2320-3-git-send-email-agraf@suse.de> <7A013D44-A137-4216-A5FA-8E1C5AE98A4C@suse.de> In-Reply-To: <7A013D44-A137-4216-A5FA-8E1C5AE98A4C@suse.de> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Alexander Graf wrote: > Any reason not to commit this one? It's required for Hyper-V and > VMware ESX and lives perfectly fine without patch 1/2. Because the first one can't be committed and I wasn't sure whether you meant for this one to be included to. I take a look at committing it. Regards, Anthony Liguori > Alex > > On 05.01.2009, at 17:11, Alexander Graf wrote: > >> As part of my ongoing effort to make nested SVM useful, I started >> working to get >> VMware ESX run inside KVM. >> >> VMware couples itself pretty tightly to the CPUID, so it's a good >> idea to emulate >> a machine that officially supports SVM and should thus exploit the >> powers of >> nested virtualization. >> >> This patch adds a Phenom CPU identifier, that resembles a real-world >> phenom >> CPU as closely as possible. >> >> Signed-off-by: Alexander Graf >> --- >> target-i386/helper.c | 27 +++++++++++++++++++++++++++ >> 1 files changed, 27 insertions(+), 0 deletions(-) >> >> diff --git a/target-i386/helper.c b/target-i386/helper.c >> index a28ab93..c709ad8 100644 >> --- a/target-i386/helper.c >> +++ b/target-i386/helper.c >> @@ -137,6 +137,33 @@ static x86_def_t x86_defs[] = { >> .model_id = "QEMU Virtual CPU version " QEMU_VERSION, >> }, >> { >> + .name = "phenom", >> + .level = 5, >> + .vendor1 = CPUID_VENDOR_AMD_1, >> + .vendor2 = CPUID_VENDOR_AMD_2, >> + .vendor3 = CPUID_VENDOR_AMD_3, >> + .family = 16, >> + .model = 2, >> + .stepping = 3, >> + /* Missing: CPUID_VME, CPUID_HT */ >> + .features = PPRO_FEATURES | >> + CPUID_MTRR | CPUID_CLFLUSH | CPUID_MCA | >> + CPUID_PSE36, >> + /* Missing: CPUID_EXT_CX16, CPUID_EXT_POPCNT */ >> + .ext_features = CPUID_EXT_SSE3 | CPUID_EXT_MONITOR, >> + /* Missing: CPUID_EXT2_FFXSR, CPUID_EXT2_PDPE1GB, >> CPUID_EXT2_RDTSCP */ >> + .ext2_features = (PPRO_FEATURES & 0x0183F3FF) | >> + CPUID_EXT2_LM | CPUID_EXT2_SYSCALL | CPUID_EXT2_NX | >> + CPUID_EXT2_3DNOW | CPUID_EXT2_3DNOWEXT | CPUID_EXT2_MMXEXT, >> + /* Missing: CPUID_EXT3_LAHF_LM, CPUID_EXT3_CMP_LEG, >> CPUID_EXT3_EXTAPIC, >> + CPUID_EXT3_CR8LEG, CPUID_EXT3_ABM, >> CPUID_EXT3_SSE4A, >> + CPUID_EXT3_MISALIGNSSE, CPUID_EXT3_3DNOWPREFETCH, >> + CPUID_EXT3_OSVW, CPUID_EXT3_IBS */ >> + .ext3_features = CPUID_EXT3_SVM, >> + .xlevel = 0x8000001A, >> + .model_id = "AMD Phenom(tm) 9550 Quad-Core Processor" >> + }, >> + { >> .name = "core2duo", >> .level = 10, >> .family = 6, >> -- >> 1.5.6 >> >> >> > > >