From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LLv8o-0001NV-J6 for qemu-devel@nongnu.org; Sun, 11 Jan 2009 02:53:50 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LLv8k-0001NJ-Nc for qemu-devel@nongnu.org; Sun, 11 Jan 2009 02:53:50 -0500 Received: from [199.232.76.173] (port=53203 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LLv8k-0001NG-Kx for qemu-devel@nongnu.org; Sun, 11 Jan 2009 02:53:46 -0500 Received: from mx20.gnu.org ([199.232.41.8]:18594) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1LLv8j-0006Lp-Kr for qemu-devel@nongnu.org; Sun, 11 Jan 2009 02:53:45 -0500 Received: from mx2.redhat.com ([66.187.237.31]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1LLv8i-0001YD-0i for qemu-devel@nongnu.org; Sun, 11 Jan 2009 02:53:44 -0500 Message-ID: <4969A57D.2020708@redhat.com> Date: Sun, 11 Jan 2009 09:53:33 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] [RFC] Variable video ram size option References: <4967A96B.3020902@eu.citrix.com> In-Reply-To: <4967A96B.3020902@eu.citrix.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: trolle.selander@eu.citrix.com Cc: qemu-devel@nongnu.org Trolle Selander wrote: > These patches are "extracted" from a patch-set I made for Xen. Any > xen-specific parts have been removed. The patches do away with the > statically defined VGA_RAM_ SIZE and provides a new -videoram option > to enable setting the amount of video ram available to the VM. > Shrinking default video ram used to 4 Megs (which is all that the > default Cirrus card can use, anyway - previously, there's been a > "waste" of 4 megs with the statically defined 8 Megs), but allowing > users to specify up to 16 Megs of vram, to support the very high > resolutions such as 2560x1600x32 that are available on today's > high-end displays. > The vgabios patch is needed for this to work, both for the variable > size video ram, and to add the new resolutions. The defines for the > high resolution and wide-screen modes were taken from what is already > in qemu-kvm, so getting this into qemu mainline should get qemu/kvm & > xen "in sync" in this regard. > > Special thanks to Stefano Stabellini for comments & constructive > criticism, and some save/restore fixes on the Xen version of this > patch-set. > > I'll brace myself for reports of how this patch breaks all the non-x86 > architectures that qemu emulates... :) > @@ -178,7 +178,7 @@ > to store the VM snapshots */ > DriveInfo drives_table[MAX_DRIVES+1]; > int nb_drives; > -static int vga_ram_size; > +static int vga_ram_size = 4 * 1024 * 1024; > enum vga_retrace_method vga_retrace_method = VGA_RETRACE_DUMB; > DisplayState display_state; > int nographic; You're changing the default, which will break existing setups. -- error compiling committee.c: too many arguments to function