qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: qemu-devel@nongnu.org
Cc: Mark McLoughlin <markmc@redhat.com>,
	Paul Brook <paul@codesourcery.com>,
	Alex Williamson <alex.williamson@hp.com>,
	kvm <kvm@vger.kernel.org>
Subject: Re: [Qemu-devel] [PATCH 0/5][RFC] virtio-net: MAC filtering
Date: Sun, 11 Jan 2009 10:32:05 +0200	[thread overview]
Message-ID: <4969AE85.60200@redhat.com> (raw)
In-Reply-To: <4967A84E.9080908@codemonkey.ws>

Anthony Liguori wrote:
> Paul Brook wrote:
>>> A concern here is the growing size of the virtio-net I/O port space
>>> config.  This series brings it up to 256 bytes with PCI resource
>>> rounding.  The VLAN filter bitmap would increase that by another 512
>>> bytes, making it 1kB and limiting us to something less than 64 such
>>> devices per guest.  Is anyone worried?  Should filter tables live in
>>> MMIO space for virtio devices?  I'll send out the guest side patches 
>>> for
>>> virtio-net in a separate thread.  Thanks,
>>>     
>>
>> This is one reason why IO ports are a reallybad idea. Use memory 
>> mapped register spaces like any other sane system and you won't have 
>> a problem.
>>   
>
> IO ports are much faster for notification than MMIO in KVM which is 
> why the space is currently IO ports.  It was never meant to hold very 
> large amounts of data.

We can, btw, fix the mmio speed issue by adding two new hypercalls: 
mmio_read() and mmio_write().  We could then hook <asm/io.h> to use the 
hypercalls instead of reading directly.  This would speed up most 
emulated devices, not just virtio.

I don't know whether Windows drivers access mmio using helpers or directly.

-- 
error compiling committee.c: too many arguments to function

  parent reply	other threads:[~2009-01-11  8:33 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-07 17:37 [Qemu-devel] [PATCH 0/5][RFC] virtio-net: MAC filtering Alex Williamson
2009-01-09 19:27 ` Paul Brook
2009-01-09 19:37   ` Avi Kivity
2009-01-09 19:41   ` Anthony Liguori
2009-01-09 19:56     ` Paul Brook
2009-01-09 20:00       ` Anthony Liguori
2009-01-11  8:32     ` Avi Kivity [this message]
2009-01-13 21:23 ` [Qemu-devel] [PATCH 0/5] " Alex Williamson
2009-01-13 21:54   ` [Qemu-devel] " Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4969AE85.60200@redhat.com \
    --to=avi@redhat.com \
    --cc=alex.williamson@hp.com \
    --cc=kvm@vger.kernel.org \
    --cc=markmc@redhat.com \
    --cc=paul@codesourcery.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).