From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LM79H-0003HG-96
	for qemu-devel@nongnu.org; Sun, 11 Jan 2009 15:43:07 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LM79C-0003CV-PM
	for qemu-devel@nongnu.org; Sun, 11 Jan 2009 15:43:06 -0500
Received: from [199.232.76.173] (port=40173 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LM79C-0003CM-K6
	for qemu-devel@nongnu.org; Sun, 11 Jan 2009 15:43:02 -0500
Received: from mx2.redhat.com ([66.187.237.31]:38899)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <uril@redhat.com>) id 1LM79C-0007no-5B
	for qemu-devel@nongnu.org; Sun, 11 Jan 2009 15:43:02 -0500
Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26])
	by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id n0BKh1Vb028679
	for <qemu-devel@nongnu.org>; Sun, 11 Jan 2009 15:43:01 -0500
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])
	by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id n0BKh1Uw002254
	for <qemu-devel@nongnu.org>; Sun, 11 Jan 2009 15:43:01 -0500
Received: from [10.35.1.187] (dhcp-1-187.tlv.redhat.com [10.35.1.187])
	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n0BKh0SK020014
	for <qemu-devel@nongnu.org>; Sun, 11 Jan 2009 15:43:00 -0500
Message-ID: <496A59D2.6070707@redhat.com>
Date: Sun, 11 Jan 2009 22:42:58 +0200
From: Uri Lublin <uril@redhat.com>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] qemu: block.c: introducing "fmt:FMT:" prefix to
	image-filenames
References: <496642BD.4010706@redhat.com>	<20090108185256.GA8669@redhat.com>	<49664F54.7050908@redhat.com>	<20090108191301.GB8669@redhat.com>	<496650ED.1060602@redhat.com>	<20090108231854.GB12848@shareable.org>
	<49671618.3080102@suse.de>
In-Reply-To: <49671618.3080102@suse.de>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Kevin Wolf wrote:
> Jamie Lokier schrieb:
>> Uri Lublin wrote:
>>> Daniel P. Berrange wrote:
>>>> Yes the format you write into the qcow2 header can still use the 
>>>> fmt:qcow2: prefix - just no need to expose that particular qcow2
>>>> specific implementation detail on the CLI. 
>>> OK. I'll prepare a patch that adds '-F fmt' to 'qemu-img create -b ...'
>> Will it break backing files whose filename begins with "fmt:"?
>>
>> Just because I hate hidden "some filenames work, some filenames break
>> mysteriously, and of course it's not documented" dodgy hacks.
> 
> Uri, now that you are making the change in qcow2 instead of block.c,
> have you thought about using the earlier suggested "filename.img\0qcow2"
> hack? This shouldn't break filenames.
> 

Hi Kevin,

1. The change is still in block.c, as the backing file is opened in 
bdrv_open2(), and also we must support raw format as a backing_file format (and 
basically any format).
2. I thought everyone agreed that "filename.img\0qcow2" would work, but that we 
should try a different solution.
3. This patch does not make things worse (with regards to "unsupported 
filename"). Without it too, qemu will refuse to run a filename that begins with 
"fmt:"

Thanks,
     Uri.