From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LMoWk-0000Mv-4t
	for qemu-devel@nongnu.org; Tue, 13 Jan 2009 14:02:14 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LMoWj-0000M0-2z
	for qemu-devel@nongnu.org; Tue, 13 Jan 2009 14:02:13 -0500
Received: from [199.232.76.173] (port=52249 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LMoWi-0000Lm-Vh
	for qemu-devel@nongnu.org; Tue, 13 Jan 2009 14:02:13 -0500
Received: from mail-ew0-f21.google.com ([209.85.219.21]:64282)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LMoWi-0006C3-Db
	for qemu-devel@nongnu.org; Tue, 13 Jan 2009 14:02:12 -0500
Received: by ewy14 with SMTP id 14so202803ewy.10
	for <qemu-devel@nongnu.org>; Tue, 13 Jan 2009 11:02:11 -0800 (PST)
Message-ID: <496CE528.5090509@codemonkey.ws>
Date: Tue, 13 Jan 2009 13:02:00 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [6215] snapshot subcommand for qemu-img (Kevin Wolf)
References: <E1LKcO7-0005k9-Rm@cvs.savannah.gnu.org>
In-Reply-To: <E1LKcO7-0005k9-Rm@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@suse.de>

Anthony Liguori wrote:
> +static void img_snapshot(int argc, char **argv)
> +{
> +    BlockDriverState *bs;
> +    QEMUSnapshotInfo sn;
> +    char *filename, *snapshot_name = NULL;
> +    char c;
> +    int ret;
> +    int action = 0;
> +    qemu_timeval tv;
> +
> +    /* Parse commandline parameters */
> +    for(;;) {
> +        c = getopt(argc, argv, "la:c:d:h");
> +        if (c == -1)
> +            break;
>   

char's are not always signed so this code is incorrect.  You should use 
an int instead.  Can you send another patch fixing this please?

Regards,

Anthony Liguori