From: Anthony Liguori <anthony@codemonkey.ws>
To: Mark McLoughlin <markmc@redhat.com>
Cc: John Wong <johnw@wonghome.net>, qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Re: [PATCH] Fix tap downscript argument
Date: Tue, 13 Jan 2009 13:16:03 -0600 [thread overview]
Message-ID: <496CE873.7050403@codemonkey.ws> (raw)
In-Reply-To: <1231872879.4290.252.camel@localhost.localdomain>
Mark McLoughlin wrote:
> Kill off the hack that parses info_str for the tap interface
> name to pass as the argument to the downscript and, instead,
> just explicitly keep a copy of the string for later.
>
> As reported by John Wong, this commit:
>
> Add qemu_format_nic_info_str()
>
> changed the invocation of downscript from e.g.
>
> /path/kvm-ifdown "tap0"
>
> to:
>
> /path/kvm-ifdown "tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown"
>
> This fix restores the original behavior.
>
> Reported-by: John Wong <johnw@wonghome.net>
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Applied. Thanks.
Regards,
Anthony Liguori
next prev parent reply other threads:[~2009-01-13 19:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 18:54 [Qemu-devel] [PATCH] Fix tap downscript argument Mark McLoughlin
2009-01-13 19:16 ` Anthony Liguori [this message]
2009-01-14 12:49 ` [Qemu-devel] " John Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=496CE873.7050403@codemonkey.ws \
--to=anthony@codemonkey.ws \
--cc=johnw@wonghome.net \
--cc=markmc@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).