From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LMokL-0002qu-Nm
	for qemu-devel@nongnu.org; Tue, 13 Jan 2009 14:16:17 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LMokJ-0002oj-WB
	for qemu-devel@nongnu.org; Tue, 13 Jan 2009 14:16:17 -0500
Received: from [199.232.76.173] (port=35020 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LMokJ-0002oY-O9
	for qemu-devel@nongnu.org; Tue, 13 Jan 2009 14:16:15 -0500
Received: from mail-ew0-f21.google.com ([209.85.219.21]:46483)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1LMokJ-0000Jm-FE
	for qemu-devel@nongnu.org; Tue, 13 Jan 2009 14:16:15 -0500
Received: by ewy14 with SMTP id 14so213472ewy.10
	for <qemu-devel@nongnu.org>; Tue, 13 Jan 2009 11:16:14 -0800 (PST)
Message-ID: <496CE873.7050403@codemonkey.ws>
Date: Tue, 13 Jan 2009 13:16:03 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1231872879.4290.252.camel@localhost.localdomain>
In-Reply-To: <1231872879.4290.252.camel@localhost.localdomain>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [PATCH] Fix tap downscript argument
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Mark McLoughlin <markmc@redhat.com>
Cc: John Wong <johnw@wonghome.net>, qemu-devel <qemu-devel@nongnu.org>

Mark McLoughlin wrote:
> Kill off the hack that parses info_str for the tap interface
> name to pass as the argument to the downscript and, instead,
> just explicitly keep a copy of the string for later.
>
> As reported by John Wong, this commit:
>
>   Add qemu_format_nic_info_str()
>
> changed the invocation of downscript from e.g.
>
>   /path/kvm-ifdown "tap0"
>
> to:
>
>   /path/kvm-ifdown "tap0,script=/path/kvm-ifup,downscript=/path/kvm-ifdown"
>
> This fix restores the original behavior.
>
> Reported-by: John Wong <johnw@wonghome.net>
> Signed-off-by: Mark McLoughlin <markmc@redhat.com>

Applied.  Thanks.

Regards,

Anthony Liguori